|
Brett Bergquist made changes - 11/Mar/08 09:40 PM
Julien Ponge made changes - 12/Mar/08 05:34 AM
Brett Bergquist made changes - 14/Mar/08 08:39 AM
The previous patch file that I attached had a "off by 1 bug" in that you were not able to navigate to the last panel. This patch is the correct patch to apply.
Brett Bergquist made changes - 14/Mar/08 08:40 AM
Brett, I could not apply your patch to the current trunk revision as there are some seriously conflicting changes. Could you please check against http://svn.codehaus.org/izpack/izpack-src/trunk/ Thank you very much!
Julien Ponge made changes - 24/Mar/08 07:54 AM
Julien Ponge made changes - 27/Mar/08 05:47 PM
New patch against the latest trunk. This patch does away with the recursion to find the next or previous panel that can be navigated to and also takes into consideration of hidden (not visible) panels. It adds a couple of new methods (hasNavigateNext, hasNavigatePrevious) that are used as utility methods to determine if there is a next or previous panel to navigate to depending on the current conditions and panel visibility.
Brett Bergquist made changes - 20/Apr/08 12:00 PM
Works like a charm, thanks a lot for your work!
Julien Ponge made changes - 20/Apr/08 12:17 PM
The issue is confirmed to be closed.
Julien Ponge made changes - 23/Apr/08 02:02 PM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This patch changes adds two new methods "hasNavigateNext" and "hasNavigatePrevious" which when called with the current panel number return the next or previous panel number that can be shown with the current conditions in effect or -1 if there is no next or previous panel that can be show. The current "navigateNext" and "navigatePrevious" are changed from their recursive form to call these new methods.
Note that this patch is not against the latest version in the trunk as that has changed a bit since I pulled out the code.