Issue Details (XML | Word | Printable)

Key: IZPACK-263
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Julien Ponge
Reporter: Florian Buehlmann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
IzPack

Allows the configuration of the path where the uninstaller is written to

Created: 19/Jan/09 05:52 AM   Updated: 20/Apr/09 03:26 AM   Resolved: 22/Jan/09 09:00 AM
Return to search
Component/s: Compiler, Installer
Affects Version/s: 4.2.0, 4.3.0
Fix Version/s: 4.3.0

Time Tracking:
Not Specified

File Attachments: 1. Text File UninstallPath_Code.patch (4 kB)
2. Text File UninstallPath_Doc.patch (2 kB)


Patch Submitted: Yes


 Description  « Hide

For the moment it is only possible to customize the name of the uninstaller (jar file name).
It would be nice if a user can customize the path where the uninstaller file is written to.
This could be configured like the following <info> entry:
<uninstaller name="uninstaller.jar" path="$NSTALL_PATH/app_remover">yes</uninstaller>



Julien Ponge made changes - 20/Jan/09 02:13 PM
Field Original Value New Value
Assignee Julien Ponge [ jponge ]
Julien Ponge added a comment - 20/Jan/09 02:15 PM

I agree with the proposed new feature, but the patch needs to be improved:

  • with an update to the documentation in src/doc-reST
  • if possible, a reformating with curly braces on the next line so as to match our prefered code style.

Florian Buehlmann added a comment - 21/Jan/09 02:51 AM

Attached two patches. The DOC patch includes the documentation changes.
The CODE patch is a reformated patch that should only include the needed changes to the code with the right formating.


Florian Buehlmann made changes - 21/Jan/09 02:51 AM
Attachment UninstallPath_Doc.patch [ 39479 ]
Attachment UninstallPath_Code.patch [ 39478 ]
Florian Buehlmann made changes - 21/Jan/09 02:52 AM
Attachment CustomizableUninstallPath.patch [ 39421 ]
Florian Buehlmann added a comment - 21/Jan/09 02:53 AM

I removed the first patch file because it was badly formated code and contained to much changes.


Julien Ponge made changes - 22/Jan/09 09:00 AM
Resolution Fixed [ 1 ]
Fix Version/s 4.2.1 [ 14764 ]
Status Open [ 1 ] Resolved [ 5 ]
Julien Ponge made changes - 22/Jan/09 02:37 PM
Affects Version/s 4.3.0 [ 14763 ]
Fix Version/s 4.2.1 [ 14764 ]
Fix Version/s 4.3.0 [ 14763 ]
Julien Ponge made changes - 20/Apr/09 03:26 AM
Status Resolved [ 5 ] Closed [ 6 ]