IzPack

Parsing application version from program-source file

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 4.2.0, 4.3.0
  • Fix Version/s: 4.3.0
  • Component/s: Compiler
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The attached patch adds support for parsing the application version value from a program-source file. Here is modified documentation for "installation-files.html":

<appversion> : the application version. The version value may be specified directly, or it can be parsed from an application source file via the following attributes:
specSourceFile : path and name of file to be parsed.
specMatchString : match string of characters before version value.
After the match string, spaces, an equals sign, and surrounding double-quotes will be removed (if found). Example usage:
<appversion specSourceFile="../lib/com/izforge/izpack/compiler/Compiler.java"
specMatchString="public final static String IZPACK_VERSION"/>

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Julien Ponge added a comment -

I am not very convinced by the usefulness of this feature.

Why not simply use text substitution mechanisms as found in Ant or Maven to replace strings in your installer XML descriptor, Java classes and more?

Show
Julien Ponge added a comment - I am not very convinced by the usefulness of this feature. Why not simply use text substitution mechanisms as found in Ant or Maven to replace strings in your installer XML descriptor, Java classes and more?
Hide
Permalink
Eric Thomas added a comment -

I use JBuilder, so ant/maven is not available for text substitution. The VERSION definition in my application source file controls the program version, so this patch allows me to set the version value in just one place (the same place I always have). I think that simply setting the version value in a source file is pretty common out there.

Show
Eric Thomas added a comment - I use JBuilder, so ant/maven is not available for text substitution. The VERSION definition in my application source file controls the program version, so this patch allows me to set the version value in just one place (the same place I always have). I think that simply setting the version value in a source file is pretty common out there.
Hide
Permalink
Julien Ponge added a comment -

I take the decision of rejecting the proposed change, sorry...

Show
Julien Ponge added a comment - I take the decision of rejecting the proposed change, sorry...

People

  • Assignee:
    Julien Ponge
    Reporter:
    Eric Thomas
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: