Conditions on packs do not work properly

Initially staged for 4.1.1, but Dennis you can move it to another version if timing is an issue.

The conditions where only noted in the pack objects but not actually read in and put into the packconditions list when initializing the Rules Engine.

Please note, that every pack has to have an id attribute to work with conditions.

I tested this today and the problem still seems to exists in 4.2.

here are the files...

install.xml:
<?xml version="1.0"?>
<installation version="1.0">
<info>
<appname>Conditions Test</appname>
<appversion>0.1</appversion>
</info>

<guiprefs resizable="yes" width="700" height="450">
<laf name="looks">
<os family="windows" />
</laf>
<modifier value="true" key="showDebugWindow" />
</guiprefs>

<locale>
<langpack iso3="eng" />
</locale>

<resources>
<res src="userInputSpec.xml" id="userInputSpec.xml" />
</resources>

<conditions>
<condition type="variable" id="pack.choice.A">
<name>testcase.option</name>
<value>A</value>
</condition>
</conditions>

<panels>
<panel classname="UserInputPanel" />
<panel classname="PacksPanel" />
<panel classname="SummaryPanel" />
</panels>

<packs>
<pack name="Pack 1" required="no" preselected="yes" id="1">
<description><![CDATA[Main Pack -- should be seen no matter what]]></description>
</pack>
<pack name="Pack 2" id="2" required="no" condition="!pack.choice.A">
<description><![CDATA[If user chose Option A, This should not be seen]]></description>
</pack>
<pack name="Pack 3" id="3" required="no" condition="pack.choice.A">
<description><![CDATA[If user chose Option B, This should not be seen]]></description>
</pack>
</packs>

</installation>

userInputSpec.xml:
<userInput>
<panel order="0">
<field type="title" bold="true" txt="Choose an Option" />
<field type="combo" variable="testcase.option">
<description align="left"
txt="Option to switch packages on next panel"
id="description.testcase.option" />
<spec txt="Choose : ">
<choice txt="Option A" value="A" />
<choice txt="Option B" value="B" />
</spec>
</field>
</panel>
</userInput>

Dennis, can you please have a look?

Thanks

Pack conditions only work with a conditions.xml resource using <packcondition> [RulesEngine.readConditions( ) ] . If the conditions.xml is used, the pack in the PacksPanel will show disabled (grey).

Normally, the conditions are loaded from the "/rules" jar resources. This data does not have pack conditions stored, only the data from <conditions>.

The unpacker checks the conditions using pack.getConditions( ) so that if the pack condition is set, the pack will not be installed.

I tested this before the release without a conditions.xml, so just by adding it to the install xml and it worked fine. I'll recheck this soon.

Hi, I'm having this problem using 4.0 version. Is this solved in 4.2?, I compared the code of both versions and I didn't find any changes. Could you tell me, if it's solved, which classes changed for the solution?
If it's not solved, when do you expect it will be?

Thank you very much.

What is exactly your problem?

Packs with non-fulfilled conditions will still be shown in the packs panel, but they will not be selectable and will not be automatically selected. So please make sure, that this isn't what you expected.