IzPack

InstallPanel overall progress bar should be indeterminate if there is only one pack to install

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 4.0.1
  • Fix Version/s: 4.3.6, 5.0
  • Component/s: Panels
  • Labels:
    None
  • Number of attachments :
    0

Description

InstallPanel overall progress bar should be indeterminate if there is only one pack to install.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Julien Ponge added a comment -

Fixed.

Show
Julien Ponge added a comment - Fixed.
Hide
Permalink
Yardena added a comment -

The issue still happens to us with 4.3.5. Looking at InstallPanel source, the test (noOfPacks == 1) in the constructor is always false, since noOfPacks is initialized to 0, and it changes to the actual value only in startAction method. So setIndeterminate(true) should probably be placed in startAction method.

Show
Yardena added a comment - The issue still happens to us with 4.3.5. Looking at InstallPanel source, the test (noOfPacks == 1) in the constructor is always false, since noOfPacks is initialized to 0, and it changes to the actual value only in startAction method. So setIndeterminate(true) should probably be placed in startAction method.
Hide
Permalink
Yardena added a comment -

I added a pull request for my fix: https://github.com/izpack/izpack/pull/16

Show
Yardena added a comment - I added a pull request for my fix: https://github.com/izpack/izpack/pull/16
Hide
Permalink
Tim Anderson added a comment -

The change has been applied for 4.3.6.
The corresponding fix for 5.0 is available at: https://github.com/izpack/izpack/pull/17

Show
Tim Anderson added a comment - The change has been applied for 4.3.6. The corresponding fix for 5.0 is available at: https://github.com/izpack/izpack/pull/17
Hide
Permalink
Tim Anderson added a comment -

Fixed applied to 5.0

Show
Tim Anderson added a comment - Fixed applied to 5.0

People

  • Assignee:
    Tim Anderson
    Reporter:
    Julien Ponge
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: