Issue Details (XML | Word | Printable)

Key: IZPACK-151
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Julien Ponge
Reporter: Thomas Diesler
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
IzPack

file unpack does not work with war files

Created: 29/Aug/08 02:57 AM   Updated: 25/Sep/08 02:45 AM
Component/s: Compiler
Affects Version/s: 4.0.0
Fix Version/s: 4.1.0

Time Tracking:
Not Specified


 Description  « Hide
Christophe ROCHEFOLLE sais,

In CompilerConfig, to check if we have to unpack a file, we have the
following line:

boolean unpack = src.endsWith(".zip") &&
true".equalsIgnoreCase(f.getAttribute("unpack"));

In my setup, I need to unpack a WAR files to be able to customize some
resource file depending of current installation, so I change it to:

boolean unpack = (src.endsWith(".zip") || src.endsWith(".war")) &&
"true".equalsIgnoreCase(f.getAttribute("unpack"));

To follow current rule, but I suggest removing the extension to test to put:

boolean unpack = "true".equalsIgnoreCase(f.getAttribute("unpack"));

It is the responsibility of the setup designer to provide a true archive
file, what do you think about it?

Kriss

http://izpack.org/community/berlios-lists-archives/izpack-users/2007-June/001543.html



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Julien Ponge added a comment - 03/Sep/08 04:25 AM
This has been fixed as:
boolean unpack = "true".equalsIgnoreCase(f.getAttribute("unpack"));

Thanks for reporting this!


Thomas Diesler added a comment - 03/Sep/08 09:57 AM
merci