IzPack

file unpack does not work with war files

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 4.0.0
  • Fix Version/s: 4.1.0
  • Component/s: Compiler
  • Labels:
    None
  • Number of attachments :
    0

Description

Christophe ROCHEFOLLE sais,

In CompilerConfig, to check if we have to unpack a file, we have the
following line:

boolean unpack = src.endsWith(".zip") &&
true".equalsIgnoreCase(f.getAttribute("unpack"));

In my setup, I need to unpack a WAR files to be able to customize some
resource file depending of current installation, so I change it to:

boolean unpack = (src.endsWith(".zip") || src.endsWith(".war")) &&
"true".equalsIgnoreCase(f.getAttribute("unpack"));

To follow current rule, but I suggest removing the extension to test to put:

boolean unpack = "true".equalsIgnoreCase(f.getAttribute("unpack"));

It is the responsibility of the setup designer to provide a true archive
file, what do you think about it?

Kriss

http://izpack.org/community/berlios-lists-archives/izpack-users/2007-June/001543.html

Activity

Hide
Julien Ponge added a comment -

This has been fixed as:

boolean unpack = "true".equalsIgnoreCase(f.getAttribute("unpack"));

Thanks for reporting this!

Show
Julien Ponge added a comment - This has been fixed as:
boolean unpack = "true".equalsIgnoreCase(f.getAttribute("unpack"));
Thanks for reporting this!
Hide
Thomas Diesler added a comment -

merci

Show
Thomas Diesler added a comment - merci

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: