Haus Chores

Code samples are invisible since the latest Confluence upgrade

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Confluence
  • Labels:
    None
  • Number of attachments :
    0

Description

Since the latest confluence upgrade, our code samples are invisible: if you look at http://cargo.codehaus.org/Functional+testing you'll see that all code samples are not visible.

Some analysis shows that the code sample is not in a block like:

<script class="theme: Confluence; brush: java; gutter: false" type="syntaxhighlighter"><![CDATA[import junit.extensions.TestSetup;
import junit.framework.Test;
[...]
}]]></script>

and Firebug shows that the "diplay" CSS attribute is somehow set to "none".

Can you please help ASAP?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ben Walding added a comment -

Confluence has switched to using a javascript syntax highlighter to format the content. I tried adding some of their javsscript to the page but there is something missing still.

In the interim your best bet is to switch the content to "noformat" rather than "code" blocks.

I think it should be possible to get the syntax highlighting going, but not today.

Show
Ben Walding added a comment - Confluence has switched to using a javascript syntax highlighter to format the content. I tried adding some of their javsscript to the page but there is something missing still. In the interim your best bet is to switch the content to "noformat" rather than "code" blocks. I think it should be possible to get the syntax highlighting going, but not today.
Hide
Permalink
Savas Ali Tokmen added a comment - - edited

This is going to be pretty hard ... :o

I've meanwhile done a small modification with Firebug and replacing the <script> with a <pre> does that replacement automatically.

I've attempted to replace the $!

{pageFragment}

with:

          $!{pageFragment
            .replace("<script ", "<pre>")
            .replace("<![CDATA[", "")
            .replace("]]></script>", "</pre>")}

but it still does not work (I believe my "replace" statements are not taken into account).

Can you help?

Show
Savas Ali Tokmen added a comment - - edited This is going to be pretty hard ... :o I've meanwhile done a small modification with Firebug and replacing the <script> with a <pre> does that replacement automatically. I've attempted to replace the $! {pageFragment} with: $!{pageFragment .replace("<script ", "<pre>") .replace("<![CDATA[", "") .replace("]]></script>", "</pre>")} but it still does not work (I believe my "replace" statements are not taken into account). Can you help?
Hide
Permalink
Ben Walding added a comment - - edited

I'm glad I've finally got some jQuery-fu (although a true master will laugh at my feeble code).

jQuery(function() {

  jQuery.fixSyntaxBlocks = function() {
    var i;
    var ccs = jQuery('div.codeContent');
    
    for (i = 0; i < ccs.length; i++) {
      var cc = jQuery(ccs[i]);
      var script = cc.find('script');
      var pre = jQuery('<pre/>');
      
      var content = script.text();
      content = content.substring(9, content.length - 3);
      pre.text(jQuery('<div/>').text(content).html());

      cc.remove('script');
      cc.append(pre);
    }
  };
  jQuery.fixSyntaxBlocks();
});
Show
Ben Walding added a comment - - edited I'm glad I've finally got some jQuery-fu (although a true master will laugh at my feeble code). jQuery(function() { jQuery.fixSyntaxBlocks = function() { var i; var ccs = jQuery('div.codeContent'); for (i = 0; i < ccs.length; i++) { var cc = jQuery(ccs[i]); var script = cc.find('script'); var pre = jQuery('<pre/>'); var content = script.text(); content = content.substring(9, content.length - 3); pre.text(jQuery('<div/>').text(content).html()); cc.remove('script'); cc.append(pre); } }; jQuery.fixSyntaxBlocks(); });
Hide
Permalink
Savas Ali Tokmen added a comment -

Thank you for your very well working code, Ben

Show
Savas Ali Tokmen added a comment - Thank you for your very well working code, Ben
Hide
Permalink
Savas Ali Tokmen added a comment -

Hi Ben

The JQuery has an issue: is transforms XML code, for example the ones in http://cargo.codehaus.org/Static+deployment+of+WAR into unreadable things (with HTML escape codes).

Can you please check again?

Show
Savas Ali Tokmen added a comment - Hi Ben The JQuery has an issue: is transforms XML code, for example the ones in http://cargo.codehaus.org/Static+deployment+of+WAR into unreadable things (with HTML escape codes). Can you please check again?
Hide
Permalink
Savas Ali Tokmen added a comment - - edited

I have replaced with the following JQuery code which seems to work better:

    jQuery(function() {

      jQuery.fixSyntaxBlocks = function() {
        var i;
        var ccs = jQuery('div.codeContent');

        for (i = 0; i < ccs.length; i++) {
          var cc = jQuery(ccs[i]);
          var script = cc.find('script');
          var pre = jQuery('<pre/>');

          var content = script.text();
          //content = '<!' + content.substring(4, content.length - 3) + ']]>';
          content = content.substring(9, content.length - 3);
          // unescape HTML
          var htmlNode = document.createElement("DIV");
          htmlNode.innerHTML = content;
          if (htmlNode.innerText !== undefined) {
            content = htmlNode.innerText; // IE
          } else {
            content = htmlNode.textContent; // FF
          }
          pre.text(content);

          cc.remove('script');
          cc.append(pre);
        }
      };
      jQuery.fixSyntaxBlocks();
    });
Show
Savas Ali Tokmen added a comment - - edited I have replaced with the following JQuery code which seems to work better: jQuery(function() { jQuery.fixSyntaxBlocks = function() { var i; var ccs = jQuery('div.codeContent'); for (i = 0; i < ccs.length; i++) { var cc = jQuery(ccs[i]); var script = cc.find('script'); var pre = jQuery('<pre/>'); var content = script.text(); //content = '<!' + content.substring(4, content.length - 3) + ']]>'; content = content.substring(9, content.length - 3); // unescape HTML var htmlNode = document.createElement("DIV"); htmlNode.innerHTML = content; if (htmlNode.innerText !== undefined) { content = htmlNode.innerText; // IE } else { content = htmlNode.textContent; // FF } pre.text(content); cc.remove('script'); cc.append(pre); } }; jQuery.fixSyntaxBlocks(); });
Hide
Permalink
Savas Ali Tokmen added a comment -

OK, now looks better with this latest patch with HTML unescape

Show
Savas Ali Tokmen added a comment - OK, now looks better with this latest patch with HTML unescape
Hide
Permalink
Savas Ali Tokmen added a comment -

Hi Ben

I've realized that the JQuery code seems not to work on some versions of Internet Explorer but also when JavaScript is disabled.

I have therefore replaced the pageFragment part with with:

$!{pageFragment.toString().replaceAll("<script[^>]*>\\w*<!.CDATA.", "<pre>").replaceAll("..>\\w*</script>", "</pre>")}

This replaces the <script> and the CDATA with <pre> and </pre>

Thank you

Show
Savas Ali Tokmen added a comment - Hi Ben I've realized that the JQuery code seems not to work on some versions of Internet Explorer but also when JavaScript is disabled. I have therefore replaced the pageFragment part with with: $!{pageFragment.toString().replaceAll("<script[^>]*>\\w*<!.CDATA.", "<pre>").replaceAll("..>\\w*</script>", "</pre>")} This replaces the <script> and the CDATA with <pre> and </pre> Thank you
Hide
Permalink
Ben Walding added a comment -

Not working on Internet Explorer is a feature.

Show
Ben Walding added a comment - Not working on Internet Explorer is a feature.
Hide
Permalink
Savas Ali Tokmen added a comment -

I know, but my problem is that some people still use IE; so that feature is unpleasant to them...

Show
Savas Ali Tokmen added a comment - I know, but my problem is that some people still use IE; so that feature is unpleasant to them...

People

  • Assignee:
    Ben Walding
    Reporter:
    Savas Ali Tokmen
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: