groovy
  1. groovy
  2. GROOVY-834

Many, many compiler warnings (Eclipse 3.1 M6)

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0-JSR-1
    • Fix Version/s: 1.0-JSR-4
    • Component/s: None
    • Labels:
      None
    • Environment:
      Eclipse 3.1M6, using 1.4 compiler settings and enabled many warnings
    • Number of attachments :
      1

      Description

      See the attached "\t" separated file. It lists around 700 warnings Eclipse 3.1M6 (using 1.4 compiler settings and enabled many warnings) generates. Which ones are no-gos? Which are to be ignored?

      I start a list here, sorting out the severity type of warning descriptions.

      [ might be ignored ] (by Eclipse's and other compiler settings)

      o Access to enclosing method getCurrent() from the type T is emulated by a synthetic accessor method. Increasing its visibility will improve your performance.

      o Statement unnecessarily nested within else clause. The corresponding then clause does not complete normally.

      [ needs fix ]

      o all remaining, especially...

      o Unnecessary semicolons
      o Unnecessary casts from T to T
      o The private field f is never read locally.

      1. 700warnings.txt
        124 kB
        Christian Stein

        Issue Links

          Activity

          Hide
          Christian Stein added a comment -

          Switching to 1.5 compiler yields 1700+ warnings and the 3 errors reported in http://jira.codehaus.org/browse/GROOVY-833 ... mainly complaining about type-safety. There's lurking another 2d+ work, when Groovy is "ported" to Java 5.

          Show
          Christian Stein added a comment - Switching to 1.5 compiler yields 1700+ warnings and the 3 errors reported in http://jira.codehaus.org/browse/GROOVY-833 ... mainly complaining about type-safety. There's lurking another 2d+ work, when Groovy is "ported" to Java 5.
          Christian Stein made changes -
          Field Original Value New Value
          Link This issue is related to GROOVY-833 [ GROOVY-833 ]
          Guillaume Laforge made changes -
          Fix Version/s 1.0-JSR-4 [ 11905 ]
          Fix Version/s 1.0-JSR-3 [ 11518 ]
          Hide
          Christian Stein added a comment -

          Only 20 warnings left: 19 not needed import statements and 1 semicolon.
          Affected files are all generated by antlr - so it's more an antlr "problem".

          Show
          Christian Stein added a comment - Only 20 warnings left: 19 not needed import statements and 1 semicolon. Affected files are all generated by antlr - so it's more an antlr "problem".
          Christian Stein made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Christian Stein [ sormuras ]
          Resolution Fixed [ 1 ]
          Paul King made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Christian Stein
              Reporter:
              Christian Stein
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 days
                2d
                Remaining:
                Remaining Estimate - 2 days
                2d
                Logged:
                Time Spent - Not Specified
                Not Specified