groovy

Primitive function arguments cause VerifyError

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-9
  • Fix Version/s: 1.0-beta-10
  • Component/s: None
  • Labels:
    None
  • Environment:
    Windows XP, Java 1.4.2_06
  • Number of attachments :
    1

Description

The following code:

def foo(double x, y) {
println "x: "+x
println "y: "+y
}

foo(10.0d, 0)

causes Groovy to complain that the value passed to y is the wrong type. Making foo a member function of a class (in another file), and giving it three arguments, the function runs but y is null and the value that should go to y, goes to the third arg. At one point I had it triggering an internal error in the JVM.

Changing double to Double fixes the problem.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. GROOVY-669 groovyc creates class files that does not verify (java.lang.VerifyError)

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. GROOVY-564 Verify error with polymorphic functions

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin C. Martin added a comment -

I spent a while on it this evening, and couldn't find the problem. But I did discover that you don't need the function call or the first println, although you do need to access y. So the shortest code that produces this bug is:

def foo(double x, y) {
y
}

Everything looks fine, and the methodType in AsmClassGenerator2.visitMethod() is right:

(DLjava/lang/Object;)Ljava/lang/Object;

Maybe it's a bug in the objectweb ClassWriter?

Show
Martin C. Martin added a comment - I spent a while on it this evening, and couldn't find the problem. But I did discover that you don't need the function call or the first println, although you do need to access y. So the shortest code that produces this bug is: def foo(double x, y) { y } Everything looks fine, and the methodType in AsmClassGenerator2.visitMethod() is right: (DLjava/lang/Object;)Ljava/lang/Object; Maybe it's a bug in the objectweb ClassWriter?
Hide
Permalink
Martin C. Martin added a comment -

After a little more searching, I discovered this:

http://java.sun.com/docs/books/vmspec/2nd-edition/html/Overview.doc.html#15722

"A single local variable can hold a value of type boolean, byte, char, short, int, float, reference, or returnAddress. A pair of local variables can hold a value of type long or double."

So when an argument is a long or a double, we need to increase the index of all subsequent arguments.

Show
Martin C. Martin added a comment - After a little more searching, I discovered this: http://java.sun.com/docs/books/vmspec/2nd-edition/html/Overview.doc.html#15722 "A single local variable can hold a value of type boolean, byte, char, short, int, float, reference, or returnAddress. A pair of local variables can hold a value of type long or double." So when an argument is a long or a double, we need to increase the index of all subsequent arguments.
Hide
Permalink
james strachan added a comment -

I think this is resolved now - I've added a test case groovy.bugs.DoubleSizeParametersBug to try reproduce it and I think its fixed now?

Show
james strachan added a comment - I think this is resolved now - I've added a test case groovy.bugs.DoubleSizeParametersBug to try reproduce it and I think its fixed now?
james strachan made changes -
Field Original Value New Value
Fix Version/s 1.0-beta-10 [ 11467 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Hide
Permalink
james strachan added a comment -

fixing resolve comment

Show
james strachan added a comment - fixing resolve comment
james strachan made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Hide
Permalink
james strachan added a comment -

Just to update my previous comment - it was Pilho Kim who provided me with the bug fix on IRC - many thanks Pilho!

Show
james strachan added a comment - Just to update my previous comment - it was Pilho Kim who provided me with the bug fix on IRC - many thanks Pilho!
james strachan made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Martin C. Martin added a comment -

Adding patch for a slightly cleaner solution

Show
Martin C. Martin added a comment - Adding patch for a slightly cleaner solution
Martin C. Martin made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Hide
Permalink
Martin C. Martin added a comment -

Changes the fix; doesn't use dummy variables, instead getNextVariableID() takes size of each var into account.

Show
Martin C. Martin added a comment - Changes the fix; doesn't use dummy variables, instead getNextVariableID() takes size of each var into account.
Martin C. Martin made changes -
Attachment AsmClassGenerator2.diff [ 13877 ]
blackdrag blackdrag made changes -
Link This issue is duplicated by GROOVY-564 [ GROOVY-564 ]
blackdrag blackdrag made changes -
Link This issue is duplicated by GROOVY-669 [ GROOVY-669 ]
Martin C. Martin made changes -
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Martin C. Martin
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: