[#GROOVY-635] Overloading divide - method is called "div" not "divide"

groovy

Overloading divide - method is called "div" not "divide"

Created: 17/Sep/04 04:35 PM Updated: 24/Jun/07 05:47 AM

Component/s:

class generator

Affects Version/s:

1.0-JSR-1

Fix Version/s:

1.1-beta-2

Time Tracking:

Original Estimate:

10 minutes

Remaining Estimate:

10 minutes

Time Spent:

Not Specified

Description

« Hide

The documents describe overloading the divide operator as adding method divide() to a class.
It is in fact div(). I see this in AsmClassGenerator and AsmClassGenerator2 (not sure where else it needs to change)

For consistency the methods should either be mul() and div() or multiply() and divide(). At the moment they are multiply() and div().

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

Brian Larson added a comment - 18/Jan/05 08:55 AM

div() was chosen to avoid a conflict with BigInteger.divide(). Other methods are consistent with Groovy and therefore do not conflict.

[ Permalink | « Hide ]

Guillaume Laforge added a comment - 18/Jan/05 09:07 AM

In a former IRC log session, James decided we should use special method names for method operators (especially for method overloading). All operator methods should be called g$add(), g$xxx(), etc.