groovy

Compiler report finalize() override declaration as error

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.8.8, 2.0.4
  • Fix Version/s: None
  • Component/s: Compiler
  • Labels:
    None
  • Environment:
  • Number of attachments :
    2

Description

Under indeterminate conditions, but often on:

  • Eclipse start-up
  • code edit
  • class creation,

with auto-build enabled, the compiler reports that an override of the protected method finalize() on Object declared:

/* (non-Javadoc)
 * @see java.lang.Object#finalize()
 */
@Override
protected void finalize() throws Throwable {
        // Some behavior...
	super.finalize();
}

is incorrectly declared, and should be declared public to match that declared on Object. That declaration (on Object) is declared as protected, not public (as implied by the error message), showing that the compiler is incorrect, not the code. Also, the error is reported on an unrelated script file in the project, not the location where it was found.

I have tried to reproduce in a small project, to no success. The zip of this is attached, and reproduces the inheritance and implementation hierarchy of the original.

The error can be resolved my commenting out the overriding definition, cleaning and rebuilding. The error then goes away, and restoring the overriding definition (by e.g. restoring from a VC system) does NOT make the error re-appear.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. GROOVY-5993 Compiler fails on valid override of Object#finalize(), incorrectly reporting vsibility

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul Bennett added a comment -

Screenshot of problem. The screen is showing the location where the probem shows up, and the error in the Problems view. This has occured sometime in the last hour or so as I haev been editing and updating the code. This included creating a new class file

Show
Paul Bennett added a comment - Screenshot of problem. The screen is showing the location where the probem shows up, and the error in the Problems view. This has occured sometime in the last hour or so as I haev been editing and updating the code. This included creating a new class file
Hide
Permalink
Andrew Eisenberg added a comment -

I'm able to reproduce this.

I'm guessing that somehow the visibility of the finalize() method on Object has been corrupted and this leads to the compiler thinking that the method is public.

Assigning this to Andy since it is more in his area.

Show
Andrew Eisenberg added a comment - I'm able to reproduce this. I'm guessing that somehow the visibility of the finalize() method on Object has been corrupted and this leads to the compiler thinking that the method is public. Assigning this to Andy since it is more in his area.
Hide
Permalink
Paul Bennett added a comment - - edited

This also happens outside of Eclipse under Gradle 1.4 with Groovy 1.8.8, so it would seem that it is not a GREclipse problem, but in the Groovy compiler.

paul@windowbox:~/ws/MetaWeb$ grb
versionStamp=0.0.1-dev+svn363:402M
:Dios:compileJava UP-TO-DATE
:Dios:compileGroovy UP-TO-DATE
:Dios:processResources UP-TO-DATE
:Dios:classes UP-TO-DATE
:Dios:jar UP-TO-DATE
:MetaWeb:compileJava UP-TO-DATE
:MetaWeb:compileGroovy
startup failed:
/Users/paul/ws/MetaWeb/src/main/groovy/com/metaficient/web/gui/core/DynamicallyTypedBeanItem.groovy: 42: The method finalize should be public as it implements the corresponding method from interface java.lang.Object
. At [42:2]  @ line 42, column 2.
   	@Override
    ^

/Users/paul/ws/MetaWeb/src/main/groovy/com/metaficient/web/gui/core/CollectionContainer.groovy: 82: The method finalize should be public as it implements the corresponding method from interface java.lang.Object
. At [82:2]  @ line 82, column 2.
   	@Override
    ^

2 errors

:MetaWeb:compileGroovy FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':MetaWeb:compileGroovy'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 9.951 secs
Show
Paul Bennett added a comment - - edited This also happens outside of Eclipse under Gradle 1.4 with Groovy 1.8.8, so it would seem that it is not a GREclipse problem, but in the Groovy compiler. paul@windowbox:~/ws/MetaWeb$ grb versionStamp=0.0.1-dev+svn363:402M :Dios:compileJava UP-TO-DATE :Dios:compileGroovy UP-TO-DATE :Dios:processResources UP-TO-DATE :Dios:classes UP-TO-DATE :Dios:jar UP-TO-DATE :MetaWeb:compileJava UP-TO-DATE :MetaWeb:compileGroovy startup failed: /Users/paul/ws/MetaWeb/src/main/groovy/com/metaficient/web/gui/core/DynamicallyTypedBeanItem.groovy: 42: The method finalize should be public as it implements the corresponding method from interface java.lang. Object . At [42:2] @ line 42, column 2. @Override ^ /Users/paul/ws/MetaWeb/src/main/groovy/com/metaficient/web/gui/core/CollectionContainer.groovy: 82: The method finalize should be public as it implements the corresponding method from interface java.lang. Object . At [82:2] @ line 82, column 2. @Override ^ 2 errors :MetaWeb:compileGroovy FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':MetaWeb:compileGroovy'. > Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 9.951 secs
Hide
Permalink
Andrew Eisenberg added a comment -

You're right. Also happens on Groovy 2.0.4 (and possibly later versions, haven't yet tried).

I'll migrate this over to the groovy project.

Show
Andrew Eisenberg added a comment - You're right. Also happens on Groovy 2.0.4 (and possibly later versions, haven't yet tried). I'll migrate this over to the groovy project.
Hide
Permalink
Andrew Eisenberg added a comment -

Moved this bug to the groovy project since it seems to be coming from the compiler, not greclipse.

I have confirmed the bug on 2.0.4 and Paul has confirmed it on 1.8.8. Likely exists in other versions as well.

Show
Andrew Eisenberg added a comment - Moved this bug to the groovy project since it seems to be coming from the compiler, not greclipse. I have confirmed the bug on 2.0.4 and Paul has confirmed it on 1.8.8. Likely exists in other versions as well.
Hide
Permalink
blackdrag blackdrag added a comment -

The origin of the error is Verifier.java:1121 (addCovariantMethods). This part is a check for proper usage of overrides for interface implementation methods. This means that in the case here the groovy compiler thinks Object is a interface. Doing 

interface X{}
class Foo implements X {
  protected void finalize() throws Throwable {
    super.finalize();
  }
}

I was able to reproduce the problem.

Show
blackdrag blackdrag added a comment - The origin of the error is Verifier.java:1121 (addCovariantMethods). This part is a check for proper usage of overrides for interface implementation methods. This means that in the case here the groovy compiler thinks Object is a interface. Doing interface X{} class Foo implements X { protected void finalize() throws Throwable { super .finalize(); } } I was able to reproduce the problem.

People

  • Assignee:
    Andy Clement
    Reporter:
    Paul Bennett
Vote (0)
Watch (3)

Dates

  • Created:
    Updated: