groovy

Exception passing array into Closure

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0-JSR-3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

(from the mailing list):

I wrote:

– script –
c1 = new Class[]

{ Exception.class, Throwable.class }

c2 = new Class[]

{ IllegalStateException.class }

println (c1)
println (c2)
[c1, c2].each

{println(it)}

– output –
[Ljava.lang.Class;@14da8f4
[Ljava.lang.Class;@fd68b1
Incorrect arguments to closure: CommandLine4$_run_closure1@10a2d64.
Expected: [class java.lang.Object], actual: [class java.lang.Exception,
class java.lang.Throwable]

John Wilson responded:

It's a bug

The closure code is getting confused into thinking that you are calling it with Exception.class, Throwable.class as parameters.

Issue Links

is depended upon by

Task - A task that needs to be done. GROOVY-764 closures

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. GROOVY-886 each(){} throws NPE when called on a Java Object[], that contains String[]'s with null entries

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Bing Ran added a comment -

The bytecode is fine. It has something to do arg processing in the Closure.call() I guess.

Show
Bing Ran added a comment - The bytecode is fine. It has something to do arg processing in the Closure.call() I guess.
Hide
Permalink
blackdrag blackdrag added a comment -

the reason for both problems is the same... the strange array handling in closures

Show
blackdrag blackdrag added a comment - the reason for both problems is the same... the strange array handling in closures
Hide
Permalink
Kim, Pilho added a comment -

Array handling in closure is not strange.
If we should get arrays or lists as parameters in closure, then
we should use typed parameters in closures.

So here is a workaround for Groovy 1.0 JSR-02 above..

def c1 = [ Exception.class, Throwable.class ] as Class[]
def c2 = [ IllegalStateException.class ] as Class[]
println (c1)
println (c2)
[c1, c2].each

{ Object[] x -> println(x) }
Show
Kim, Pilho added a comment - Array handling in closure is not strange. If we should get arrays or lists as parameters in closure, then we should use typed parameters in closures. So here is a workaround for Groovy 1.0 JSR-02 above.. def c1 = [ Exception.class, Throwable.class ] as Class[] def c2 = [ IllegalStateException.class ] as Class[] println (c1) println (c2) [c1, c2] .each { Object[] x -> println(x) }
Hide
Permalink
Kim, Pilho added a comment -

def c1 = [ Exception.class, Throwable.class ] as Class[]
def c2 = [ IllegalStateException.class ] as Class[]
println (c1)
println (c2)
[c1, c2].each

{println(it)}

Applying my new patches about "closure and arrays", this works good.
I would like to commit my new patches soon.

Show
Kim, Pilho added a comment - def c1 = [ Exception.class, Throwable.class ] as Class[] def c2 = [ IllegalStateException.class ] as Class[] println (c1) println (c2) [c1, c2] .each {println(it)} Applying my new patches about "closure and arrays", this works good. I would like to commit my new patches soon.
Hide
Permalink
Kim, Pilho added a comment -

This has been fixed in 1.0-JSR-3.

Show
Kim, Pilho added a comment - This has been fixed in 1.0-JSR-3.

People

  • Assignee:
    John Wilson
    Reporter:
    Darren Davison
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: