groovy

new JsonBuilder('<complex xml string>').toPrettyPrint() throws StackOverflowException

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.4
  • Fix Version/s: 1.8.7
  • Component/s: JSON
  • Labels:
    None
  • Environment:
    Windows 7, Java 6, IntelliJ IDEA
  • Number of attachments :
    0

Description

When we run the following, 

new JsonBuilder('<a a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\" a=\\"\\"/>').toPrettyPrint()

we get a StackOverflowException

 java.lang.StackOverflowError
	at java.lang.Character.codePointAt(Character.java:2335)
	at java.util.regex.Pattern$CharProperty.match(Pattern.java:3344)
	at java.util.regex.Pattern$Curly.match0(Pattern.java:3760)
	at java.util.regex.Pattern$Curly.match(Pattern.java:3744)
	at java.util.regex.Pattern$Branch.match(Pattern.java:4114)
	at java.util.regex.Pattern$GroupHead.match(Pattern.java:4168)
	at java.util.regex.Pattern$Loop.match(Pattern.java:4295)
	at java.util.regex.Pattern$GroupTail.match(Pattern.java:4227)
	at java.util.regex.Pattern$BranchConn.match(Pattern.java:4078)
	at java.util.regex.Pattern$Curly.match0(Pattern.java:3782)
	at java.util.regex.Pattern$Curly.match(Pattern.java:3744)
	at java.util.regex.Pattern$Branch.match(Pattern.java:4114)
	at java.util.regex.Pattern$GroupHead.match(Pattern.java:4168)
	at java.util.regex.Pattern$Loop.match(Pattern.java:4295)
        ...

We have made a basic change to fix the problem as an override/temporary solution as follows...

JsonTokenType.STRING.validator = Pattern.compile('"(?>[^"\\\\]+|\\\\["\\\\bfnrt\\/]|\\\\u[0-9a-fA-F]{4})*"', Pattern.DOTALL)

The main change is the addition of ?> and the change from * to +.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guillaume Laforge added a comment -

Could you please try with Groovy 1.8.7 (just released) or Groovy 2.0.1 just released as well?
There were some changes related to that in 1.8.7 and beyond.

Show
Guillaume Laforge added a comment - Could you please try with Groovy 1.8.7 (just released) or Groovy 2.0.1 just released as well? There were some changes related to that in 1.8.7 and beyond.
Hide
Permalink
Guillaume Laforge added a comment -

Also please post a valid sample reproducing the problem.

Show
Guillaume Laforge added a comment - Also please post a valid sample reproducing the problem.
Hide
Permalink
Guillaume Laforge added a comment -

Using this example worked fine for me with Groovy 2.0.1:

def txt = '<a ' + ('a=\\"\\"' * 100) + '/>'
new groovy.json.JsonBuilder(txt).toPrettyString()
Show
Guillaume Laforge added a comment - Using this example worked fine for me with Groovy 2.0.1: def txt = '<a ' + ('a=\\ "\\" ' * 100) + '/>' new groovy.json.JsonBuilder(txt).toPrettyString()
Hide
Permalink
Craig Rykal added a comment -

Thanks Guillaume! I ran your example only with 1000 instead of 100 and it definitely fails prior to 1.8.7 but works in 1.8.7 and beyond. We'll just upgrade to that version! Thanks again!

Show
Craig Rykal added a comment - Thanks Guillaume! I ran your example only with 1000 instead of 100 and it definitely fails prior to 1.8.7 but works in 1.8.7 and beyond. We'll just upgrade to that version! Thanks again!

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    Craig Rykal
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: