groovy

JsonOutput.toJson(def) fails with MissingMethodException if the object defines getProperties()

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.4
  • Fix Version/s: 1.8.7
  • Component/s: JSON
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    0

Description

If an object defines getProperties(), JsonOutput.toJson(def) fails with the following:

groovy.lang.MissingMethodException: No signature of method: com.foo.FileProperties.remove() is applicable for argument types: (java.lang.String) values: [class]
Possible solutions: getAt(java.lang.String)
...
	at groovy.json.JsonOutput.toJson(JsonOutput.groovy:131)
...

Repro:

class MyClass { String properties }
groovy.json.JsonOutput.toJson(new MyClass(properties: 'properties'))

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Suk-Hyun Cho added a comment -

Changing def properties = object.properties to def properties = DefaultGroovyMethods.getProperties(object) fixes this.

Show
Suk-Hyun Cho added a comment - Changing def properties = object.properties to def properties = DefaultGroovyMethods.getProperties(object) fixes this.
Hide
Permalink
Suk-Hyun Cho added a comment -

Note that an object declaring properties field or getProperties() method of (return) type Map will result in an incorrect result (namely, the toJson() result of the object's declared properties/getProperties(), rather than the entire object).

Commit 17ea853 unit-tests and fixes this. There is also a pull request for this in the GROOVY_1_8_X branch.

Show
Suk-Hyun Cho added a comment - Note that an object declaring properties field or getProperties() method of (return) type Map will result in an incorrect result (namely, the toJson() result of the object's declared properties/getProperties() , rather than the entire object). Commit 17ea853 unit-tests and fixes this. There is also a pull request for this in the GROOVY_1_8_X branch.
Hide
Permalink
Pascal Schumacher added a comment -

The pull request https://github.com/groovy/groovy-core/pull/56 was merged and closed, so I guess this issue can be closed too.

Show
Pascal Schumacher added a comment - The pull request https://github.com/groovy/groovy-core/pull/56 was merged and closed, so I guess this issue can be closed too.
Hide
Permalink
blackdrag blackdrag added a comment -

Guillaume, it seems you merged the request, 4 months ago already and forgot to close that. Since I don't know the fix versions I will not close it for you, can you please?

Show
blackdrag blackdrag added a comment - Guillaume, it seems you merged the request, 4 months ago already and forgot to close that. Since I don't know the fix versions I will not close it for you, can you please?
Hide
Permalink
Paul King added a comment -

updated fix version and closed

Show
Paul King added a comment - updated fix version and closed

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    Suk-Hyun Cho
Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: