groovy

HTML Builder changes & between URL parameters to &amp; when building an <a> tag

Details

  • Testcase included:
    yes
  • Number of attachments :
    2

Description

If you use a HTML builder to build an <a> tag and you have parameters in the URL the separating & is changed to a &. This is probably desirable for XML but not HTML.

Example:

def writer = new StringWriter()
def builder = new groovy.xml.MarkupBuilder(writer)
builder.a(href: "http://www.example.com?foo=1&bar=2")
println writer.toString()

This outputs <a href='http://www.example.com?foo=1&amp;bar=2' /> when it should output <a href='http://www.example.com?foo=1&bar=2' />

I have attached a test case.

  1. File
    HtmlBuilderBug.groovy
    18/May/12 2:12 PM
    0.3 kB
    Michael Parmeley
  2. File
    HtmlBuilderBugTest.groovy
    18/May/12 2:12 PM
    0.3 kB
    Michael Parmeley

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Parmeley added a comment - - edited

Please note that the actual output I tried to show didn't display correctly because Jira changed the &amp to an & inside the description. The test case will show the problem though

Show
Michael Parmeley added a comment - - edited Please note that the actual output I tried to show didn't display correctly because Jira changed the &amp to an & inside the description. The test case will show the problem though
Hide
Permalink
Michael Parmeley added a comment - - edited

The first sentence of the description should read (Jira is decoding it so the description actually doesn't make sense): "If you use a HTML builder to build an <a> tag and you have parameters in the URL the separating & is changed to a &amp" (leaving off semi-colon so jira doesn't decode it)

Show
Michael Parmeley added a comment - - edited The first sentence of the description should read (Jira is decoding it so the description actually doesn't make sense): "If you use a HTML builder to build an <a> tag and you have parameters in the URL the separating & is changed to a &amp" (leaving off semi-colon so jira doesn't decode it)
Hide
Permalink
Paul King added a comment -

Changed to a feature request since the current behavior is correct as designed. The current design allows the output produced by MarkupBuilder to be round-tripped using XmlParser or XmlSlurper. To provide the behavior you describe we would need an additional mode which didn't make such guarantees.

Show
Paul King added a comment - Changed to a feature request since the current behavior is correct as designed. The current design allows the output produced by MarkupBuilder to be round-tripped using XmlParser or XmlSlurper. To provide the behavior you describe we would need an additional mode which didn't make such guarantees.
Hide
Permalink
Paul King added a comment - - edited

A new flag has been added and used as follows:

def writer = new StringWriter()
def builder = new groovy.xml.MarkupBuilder(writer)
builder.escapeAttributes = false
builder.a(href: "http://www.example.com?foo=1&bar=2")
assert writer.toString().contains('http://www.example.com?foo=1&bar=2')
Show
Paul King added a comment - - edited A new flag has been added and used as follows: def writer = new StringWriter() def builder = new groovy.xml.MarkupBuilder(writer) builder.escapeAttributes = false builder.a(href: "http: //www.example.com?foo=1&bar=2" ) assert writer.toString().contains('http: //www.example.com?foo=1&bar=2')

People

  • Assignee:
    Paul King
    Reporter:
    Michael Parmeley
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: