groovy

Process should have a method called closeStreams()

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.6
  • Fix Version/s: 2.1.0-rc-1
  • Component/s: groovy-jdk
  • Labels:
    None
  • Number of attachments :
    0

Description

Java doesn't close streams until finalization which can result in too many open files errors sometimes. To avoid this problem, one needs to proactively close all the streams of a Process when it is finished. This currently requires 3 method calls so I propose a simple one be added to Process called closeStreams() instead.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Uri Moszkowicz added a comment -

I should probably clarify that you can also use waitForProcessOutput() but that's not always sufficient, such as when you would like to process the output as it is generated. In these cases, closeStreams() also needs to join the consumed threads if there are any.

Show
Uri Moszkowicz added a comment - I should probably clarify that you can also use waitForProcessOutput() but that's not always sufficient, such as when you would like to process the output as it is generated. In these cases, closeStreams() also needs to join the consumed threads if there are any.
Hide
Permalink
Pascal Schumacher added a comment -

created a pull request for this https://github.com/groovy/groovy-core/pull/97

Show
Pascal Schumacher added a comment - created a pull request for this https://github.com/groovy/groovy-core/pull/97
Hide
Permalink
Paul King added a comment -

Thanks!

Show
Paul King added a comment - Thanks!

People

  • Assignee:
    Paul King
    Reporter:
    Uri Moszkowicz
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: