groovy

ObjectRange doesn't have BigInteger optimisation for size()

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.6
  • Fix Version/s: 1.8.9, 2.0.7, 2.1.1
  • Component/s: groovy-jdk
  • Labels:
    None
  • Number of attachments :
    0

Description

The ObjectRange.size() method has optimisations for BigDecimal, Integer and Long, but not BigInteger

https://github.com/groovy/groovy-core/blob/master/src/main/groovy/lang/ObjectRange.java#L262

This means that calling:

(1G..2147483647G).size()

Takes ages

Could we change:

} else if (from instanceof BigInteger || to instanceof BigInteger) {

to

} else if (from instanceof BigDecimal ||
           to   instanceof BigDecimal ||
           from instanceof BigInteger ||
           to   instanceof BigInteger ) {

To catch this?

Activity

Ascending order - Click to sort in descending order
Pascal Schumacher made changes -
Field Original Value New Value
Component/s groovy-jdk [ 10750 ]
Hide
Permalink
Pascal Schumacher added a comment -

Can somebody answer Tims question? Thanks !

Show
Pascal Schumacher added a comment - Can somebody answer Tims question? Thanks !
Hide
Permalink
blackdrag blackdrag added a comment -

yes, that change can be done

Show
blackdrag blackdrag added a comment - yes, that change can be done
Hide
Permalink
Pascal Schumacher added a comment - - edited

Tim, I'm assigning this to you because I believe you want to commit the enhancement you suggested.

Show
Pascal Schumacher added a comment - - edited Tim, I'm assigning this to you because I believe you want to commit the enhancement you suggested.
Pascal Schumacher made changes -
Assignee Tim Yates [ tim_yates ]
Hide
Permalink
Tim Yates added a comment -

https://github.com/groovy/groovy-core/pull/134

Show
Tim Yates added a comment - https://github.com/groovy/groovy-core/pull/134
Tim Yates made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.1.1 [ 18990 ]
Fix Version/s 1.8.9 [ 18778 ]
Fix Version/s 2.0.7 [ 19028 ]
Resolution Fixed [ 1 ]
Paul King made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Tim Yates
    Reporter:
    Tim Yates
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: