groovy

Add findResult() to String

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: groovy-jdk
  • Labels:
    None
  • Number of attachments :
    0

Description

Collection implements a method with the following signature:

public Object findResult(Closure closure)

It would be nice if a similar method existed for String.

public Object findResult(Pattern pattern, Closure closure)

The method find() almost performs the same function except that it converts the result to a string, even if it's null or a Boolean. Alternatively, the existing find() methods could be changed to return Object instead of String. Without this method, the matching string has to be saved into a temporary variable and then processed afterwards.

Example:
if (new File("file").text.findResult(~/VAR\s*=\s*(\S+)/)

{ it[1] != "VALUE1" }

)

{ // ... }

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Uri Moszkowicz added a comment -

I omitted an important aspect of the example:

if (new File("file").text.findResult(~/VAR\s*=\s*(\S+)/) { (it[1[] =~ /VALUE0/) && (it[1] != "VALUE1"})) {
  // ...
}

A variable would be needed otherwise because it is used multiple times in the closure.

Show
Uri Moszkowicz added a comment - I omitted an important aspect of the example: if (new File("file").text.findResult(~/VAR\s*=\s*(\S+)/) { (it[1[] =~ /VALUE0/) && (it[1] != "VALUE1"})) { // ... } A variable would be needed otherwise because it is used multiple times in the closure.
Hide
Permalink
Paul King added a comment - - edited

I guess it is a little clearer than below but not by a lot:

if (new File("file").text.find(~/VAR\s*=\s*(\S+)/) { (it[1] =~ /VALUE0/ && it[1] != "VALUE1") ?: '' }) {
  // ...
}
Show
Paul King added a comment - - edited I guess it is a little clearer than below but not by a lot: if ( new File( "file" ).text.find(~/VAR\s*=\s*(\S+)/) { (it[1] =~ /VALUE0/ && it[1] != "VALUE1" ) ?: '' }) { // ... }
Hide
Permalink
Pascal Schumacher added a comment -

Is this a duplicate of GROOVY-5784 or am I missing something?

Show
Pascal Schumacher added a comment - Is this a duplicate of GROOVY-5784 or am I missing something?
Uri Moszkowicz made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Duplicate [ 3 ]
Paul King made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Uri Moszkowicz
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: