groovy

Groovy could benefit from DGM takeWhile and dropWhile methods

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.6
  • Fix Version/s: 2.0-beta-3, 1.8.7
  • Component/s: groovy-jdk
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    0

Description

Currently, there is a take method on collections that returns the first N items in a collection. Other languages such as scala and haskell also provide a takeWhile method, that is similar. Instead of taking a fixed number of items, it takes items until a condition, in the form of a closure, is met.

For example:

def items = [1,2,3,4,5,4,3,2,1]
def sublist = items.takeWhile { it < 5 }
assert sublist == [1,2,3,4]

Issue Links

is related to

New Feature - A new feature of the product, which has yet to be developed. GROOVY-4865 Add a take method to Collections, Iterators, Arrays

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Taylor added a comment -

Pull request on github:

https://github.com/groovy/groovy-core/pull/44

Show
Andrew Taylor added a comment - Pull request on github: https://github.com/groovy/groovy-core/pull/44
Hide
Permalink
Paul King added a comment -

An earlier discussion on take/drop:
http://markmail.org/thread/qnt7w45cp7fnhyxu
which begs the question about whether to also support 'dropWhile' and whether Map variants also make sense?

Show
Paul King added a comment - An earlier discussion on take/drop: http://markmail.org/thread/qnt7w45cp7fnhyxu which begs the question about whether to also support 'dropWhile' and whether Map variants also make sense?
Hide
Permalink
Paul King added a comment -

Linked this issue to the take/drop issue (GROOVY-4865) for easy reference

Show
Paul King added a comment - Linked this issue to the take/drop issue ( GROOVY-4865 ) for easy reference
Hide
Permalink
Paul King added a comment -

dropWhile and takeWhile for CharSequence are only for 2.0+ while the others were backported to 1.8.7 also. This saved adding then deprecating in DGM given the refactor of CharSequence related methods to StringGroovyMethods in 2.0.

Show
Paul King added a comment - dropWhile and takeWhile for CharSequence are only for 2.0+ while the others were backported to 1.8.7 also. This saved adding then deprecating in DGM given the refactor of CharSequence related methods to StringGroovyMethods in 2.0.

People

  • Assignee:
    Paul King
    Reporter:
    Andrew Taylor
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: