groovy

Sql DataSet fails to work with non-literals in queries (fix error message/doco)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0-beta-3
  • Fix Version/s: 2.0-beta-3, 1.8.7
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

All the examples of using findAll in the Sql DataSet class use literals for the search values of queries. Using free variables causes failure as Groovy does not implement lexical closure automatically. However this can be realized using the Closure delegate field. I therefore believe that the following example fails because the Sql.SqlWhereVisitor fails to lookup variables but assumes that all query values are literals.

import groovy.sql.DataSet
import groovy.sql.Sql

@Grapes ( [    
            @Grab ( 'org.xerial:sqlite-jdbc:3.7.2' ),
            @GrabConfig ( systemClassLoader = true )
          ] )
def database
final words = [ ]
try {
  database = Sql.newInstance ( 'jdbc:sqlite:database.db' , 'org.sqlite.JDBC')
  final wordsTable = new DataSet ( database , 'words' )
  ( 0 ..< 4 ).each { i ->
    final query = { item -> item.id == i }
    query.delegate = { i : i }
    query.resolveStrategy = Closure.DELEGATE_FIRST 
    words << wordsTable.findAll ( query ).firstRow ( ).word
  }
}
finally {
  database?.close ( )
}
println words.join ( '' )

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. GROOVY-5373 Sql DataSet fails to work with non-literals in queries (enhancement required)

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Russel Winder made changes -
Field Original Value New Value
Description All the examples of using findAll in the Sql DataSet class use literals for the search values of queries. Using free variables causes failure as Groovy does not implement lexical closure automatically. However this can be realized using the Closure delegate field. I therefore believe that the following example fails because the Sql.SqlWhereVisitor fails to lookup variables but assumes that all query values are literals.
{code}
import groovy.sql.DataSet
import groovy.sql.Sql

@Grapes ( [
            @Grab ( 'org.xerial:sqlite-jdbc:3.7.2' ),
            @GrabConfig ( systemClassLoader = true )
          ] )
def database
final words = [ ]
try {
  database = Sql.newInstance ( 'jdbc:sqlite:database.db' , 'org.sqlite.JDBC')
  final wordsTable = new DataSet ( database , 'words' )
  ( 0 ..< 4 ).each { i ->
    final query = { item -> item.id == i }
    query.delegate = { i : i }
    query.resolveStrategy = Closure.DELEGATE_FIRST
    words << wordsTable.findAll ( query ).firstRow ( ).word
  }
}
finally {
  database?.close ( )
}
println words.join ( '' )
{code} 		All the examples of using _findAll_ in the _Sql_ _DataSet_ class use literals for the search values of queries. Using free variables causes failure as Groovy does not implement lexical closure automatically. However this can be realized using the Closure delegate field. I therefore believe that the following example fails because the _Sql.SqlWhereVisitor_ fails to lookup variables but assumes that all query values are literals.
{code}
import groovy.sql.DataSet
import groovy.sql.Sql

@Grapes ( [
            @Grab ( 'org.xerial:sqlite-jdbc:3.7.2' ),
            @GrabConfig ( systemClassLoader = true )
          ] )
def database
final words = [ ]
try {
  database = Sql.newInstance ( 'jdbc:sqlite:database.db' , 'org.sqlite.JDBC')
  final wordsTable = new DataSet ( database , 'words' )
  ( 0 ..< 4 ).each { i ->
    final query = { item -> item.id == i }
    query.delegate = { i : i }
    query.resolveStrategy = Closure.DELEGATE_FIRST
    words << wordsTable.findAll ( query ).firstRow ( ).word
  }
}
finally {
  database?.close ( )
}
println words.join ( '' )
{code}
Paul King made changes -
Link This issue relates to GROOVY-5373 [ GROOVY-5373 ]
Paul King made changes -
Summary Sql DataSet fails to work with non-literals in queries Sql DataSet fails to work with non-literals in queries (fix error message/doco)
Paul King made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Paul King [ paulk ]
Fix Version/s 2.0-beta-3 [ 18244 ]
Fix Version/s 1.8.7 [ 18317 ]
Resolution Fixed [ 1 ]
Russel Winder made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Paul King
    Reporter:
    Russel Winder
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: