groovy
  1. groovy
  2. GROOVY-5349

ICO file in distribution is broken/missing

    Details

    • Number of attachments :
      0

      Description

      The groovy.ico file in the distributions (source zip, binary zip and also Windows installer) is broken.
      The one from https://fisheye.codehaus.org/browse/~raw,r=9382/groovy/trunk/groovy/groovy-core/src/tools/org/codehaus/groovy/tools/groovy.ico is fine though.
      Comparing a hexdump of both files it seems there are Unicode replace characters inserted.
      I guess you use a <copy> task with nested <filterset> or with some implicit filter from a stand-alone <filter> task to copy that file. This is not according to the <copy> tasks documentation, which states that filter may only be used with text files and will destroy binary files.

      Note: If you employ filters in your copy operation, you should limit the copy to text files. Binary files will be corrupted by the copy operation. This applies whether the filters are implicitly defined by the filter task or explicitly provided to the copy operation as filtersets. See encoding note.

        Activity

        Hide
        Pascal Schumacher added a comment -

        in the zip files created by current master (2.1), the icon is o.k.

        Show
        Pascal Schumacher added a comment - in the zip files created by current master (2.1), the icon is o.k.
        Pascal Schumacher made changes -
        Field Original Value New Value
        Assignee Pascal Schumacher [ pschumacher ]
        Pascal Schumacher made changes -
        Priority Major [ 3 ] Trivial [ 5 ]
        Pascal Schumacher made changes -
        Summary ICO file in distribution is broken ICO file in distribution is broken/missing
        Hide
        Pascal Schumacher added a comment -

        The current release 2.1.4 is missing the "groovy.ico" file. I updated the title to reflect this.

        Show
        Pascal Schumacher added a comment - The current release 2.1.4 is missing the "groovy.ico" file. I updated the title to reflect this.
        Show
        Pascal Schumacher added a comment - fixed, see: https://github.com/groovy/groovy-core/commit/6ea29c30e13fc1072e3554cf5d9fed6daf82718b
        Pascal Schumacher made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.2.0-beta-1 [ 19074 ]
        Fix Version/s 2.1.5 [ 19320 ]
        Resolution Fixed [ 1 ]
        Paul King made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Pascal Schumacher
            Reporter:
            Björn Kautler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: