Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.6
    • Fix Version/s: 2.2.0-beta-1
    • Component/s: None
    • Labels:
    • Number of attachments :
      0

      Description

      Update to more recent version: jline: 1.0 -> 2.6+ (this has a dependency on jansi, so it makes sense to also update that to 1.8)

      Involves (thanks for input from Jason Dillon): the api changes from 1->2 are mostly package name changes, some generic signatures and some spelling fixes (e.g. completor -> completer) etc.

      Possible specifics (some may become irrelevant depending on the approach taken):

      • Terminal is an intf now; use TerminalFactory to get instances of a Terminal
      • Terminal.getTerminalWidth() is now simply Terminal.getWidth()
      • ConsoleReader is now in jline.console
      • history functionality is now in jline.console.history, History is an intf now
      • completer functionality is now in jline.console.completer
      • SimpleCompletor (in groovysh) is about the same as StringsCompleter

      This will be a breaking change (albeit to a mostly internal api) since org.codehaus.groovy.tools.shell.Command has a method Completor getCompletor() which should probably be renamed to getCompleter() and will return a class in a different package.

        Issue Links

          Activity

          Paul King made changes -
          Field Original Value New Value
          Labels breaking
          Assignee Paul King [ paulk ]
          Fix Version/s 2.0-beta-3 [ 18244 ]
          Fix Version/s 1.8.7 [ 18317 ]
          Affects Version/s 2.0-beta-2 [ 18072 ]
          Affects Version/s 1.8.6 [ 18245 ]
          Priority Minor [ 4 ] Major [ 3 ]
          Description Update to more recent version: jline: 0.9.94 -> 1.0 Update to more recent version: jline: 1.0 -> 2.6+ (this has a dependency on jansi, so it makes sense to also update that to 1.8)

          Involves (thanks for input from Jason Dillon): the api changes from 1->2 are mostly package name changes, some generic signatures and some spelling fixes (e.g. completor -> completer) etc.

          Possible specifics (some may become irrelevant depending on the approach taken):
          * Terminal is an intf now; use TerminalFactory to get instances of a Terminal
          * Terminal.getTerminalWidth() is now simply Terminal.getWidth()
          * ConsoleReader is now in jline.console
          * history functionality is now in jline.console.history, History is an intf now
          * completer functionality is now in jline.console.completer
          * SimpleCompletor (in groovysh) is about the same as StringsCompleter

          This will be a breaking change (albeit to a mostly internal api) since {{org.codehaus.groovy.tools.shell.Command}} has a method {{Completor getCompletor()}} which should probably be renamed to {{getCompleter()}} and will return a class in a different package.

          Paul King made changes -
          Fix Version/s 2.0-beta-x [ 17013 ]
          Fix Version/s 2.0-beta-3 [ 18244 ]
          Paul King made changes -
          Fix Version/s 2.1.0-rc-1 [ 19026 ]
          Fix Version/s 2.x [ 17013 ]
          Guillaume Laforge made changes -
          Fix Version/s 2.1.0-rc-2 [ 19054 ]
          Fix Version/s 2.1.0-rc-1 [ 19026 ]
          Paul King made changes -
          Fix Version/s 2.1.0-rc-2 [ 19054 ]
          Affects Version/s 2.0.6 [ 18852 ]
          Affects Version/s 2.0-beta-2 [ 18072 ]
          Pascal Schumacher made changes -
          Summary Update jline dependency for 2.0 Update jline dependency
          Pascal Schumacher made changes -
          Link This issue relates to GROOVY-4503 [ GROOVY-4503 ]
          Pascal Schumacher made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Pascal Schumacher [ pschumacher ]
          Fix Version/s 2.2.0-beta-1 [ 19074 ]
          Resolution Fixed [ 1 ]
          Paul King made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Pascal Schumacher
              Reporter:
              Paul King
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: