groovy

Stub generation doesn't handle 'protected' multi-line String correctly.

Details

  • Number of attachments :
    0

Description

When using the groovyc joint compilation feature, the generated stub is incorrect when the groovy source includes a protected (possibly affects public too, I didn't test) multi-line String 'constant'.

For example,

class Example

{ protected static final String CONSTANT_VALUE = """ I am a constant value Thank you """ }

would generate a stub:

public Example extends java.lang.Object implements groovy.lang.GroovyObject

{ protected static final java.lang.String CONSTANT_VALUE = " I am a constant value Thank you "; }

This is a syntactically incorrect Java statement.

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. GROOVY-5150 Switch to a primitive representation of constants

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jay Ashworth added a comment - - edited

I apologize, the formatting wasn't preserved.
Sample code:

Example.groovy
class Example {
  protected static final String CONSTANT_VALUE = """
I am a constant value
Thank you
"""
}

Generating stub:

Example.java
public Example extends java.lang.Object implements groovy.lang.GroovyObject { 
protected static final java.lang.String CONSTANT_VALUE = "
I am a constant value
Thank you
";
}
Show
Jay Ashworth added a comment - - edited I apologize, the formatting wasn't preserved. Sample code: Example.groovy class Example { protected static final String CONSTANT_VALUE = """ I am a constant value Thank you """ } Generating stub: Example.java public Example extends java.lang. Object implements groovy.lang.GroovyObject { protected static final java.lang. String CONSTANT_VALUE = " I am a constant value Thank you "; }
Paul King made changes -
Field Original Value New Value
Link This issue relates to GROOVY-5150 [ GROOVY-5150 ]
Hide
Permalink
Paul King added a comment -

I think this is an edge case left over from GROOVY-5150

Show
Paul King added a comment - I think this is an edge case left over from GROOVY-5150
Hide
Permalink
Paul King added a comment -

Your suspicions were correct. This affected both public and protected fields but should be fixed now.

Show
Paul King added a comment - Your suspicions were correct. This affected both public and protected fields but should be fixed now.
Paul King made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Paul King [ paulk ]
Fix Version/s 2.0-beta-3 [ 18244 ]
Fix Version/s 1.8.7 [ 18317 ]
Resolution Fixed [ 1 ]
Paul King made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Paul King
    Reporter:
    Jay Ashworth
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: