groovy

New GDK method: Object[].contains()

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.5, 2.0-beta-2
  • Fix Version/s: 1.8.6, 2.0-beta-3
  • Component/s: groovy-jdk
  • Labels:
    None
  • Number of attachments :
    0

Description

We treat arrays as Lists in may respects. There are methods from List that have been grafted unto arrays however there is no contains() method which would come in handy in scenarios like the following one

if(!arrayOfObjects.contains(element)) {
    arrayOfObjects << elements
}

One way to do it currently is this

if( !(element in arrayOfObjects) ) {
    arrayOfObjects << elements
}

Notice the additional () around the expression

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. GROOVY-5273 Provide contains as a DGM method for primitive arrays

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Yates added a comment -

Looks like this is going to be in the next release...

https://github.com/groovy/groovy-core/commit/db1733a7ed270c8193727c0764005856bfcf7919

Wish I'd checked the commits before starting work on a local version

You live and learn I guess

Show
Tim Yates added a comment - Looks like this is going to be in the next release... https://github.com/groovy/groovy-core/commit/db1733a7ed270c8193727c0764005856bfcf7919 Wish I'd checked the commits before starting work on a local version You live and learn I guess
Hide
Permalink
blackdrag blackdrag added a comment -

actually the commit was for 5273, to provide a contains for primitive arrays. Object[] is still outstanding

Show
blackdrag blackdrag added a comment - actually the commit was for 5273, to provide a contains for primitive arrays. Object[] is still outstanding
Hide
Permalink
blackdrag blackdrag added a comment -

Tim, you want to take that?

Show
blackdrag blackdrag added a comment - Tim, you want to take that?
Hide
Permalink
Paul King added a comment -

I'll grab it since I added the primitive array methods.

Show
Paul King added a comment - I'll grab it since I added the primitive array methods.
Hide
Permalink
Paul King added a comment -

Fixed. Thanks for the suggestion Andres.

Show
Paul King added a comment - Fixed. Thanks for the suggestion Andres.

People

  • Assignee:
    Paul King
    Reporter:
    Andres Almiray
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: