groovy

Invalid Static Type Checking report on a method call with type parameters

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-beta-1
  • Fix Version/s: 2.0-beta-2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

The following code produces static type checking error:

import groovy.transform.*

@TypeChecked 
class Foo {
    def say() {
        FooWithGenerics f
        FooBound fb
        f.say(fb)
    }
}

class FooWithGenerics {
    def <T extends FooBound> void say(T p) {
    }
}
class FooBound {
}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roshan Dawrani added a comment -

Added code formatting tags.

Show
Roshan Dawrani added a comment - Added code formatting tags.
Roshan Dawrani made changes -
Field Original Value New Value
Description The following code produces static type checking error:

import groovy.transform.*

@TypeChecked
class Foo {
    def say() {
        FooWithGenerics f
        FooBound fb
        f.say(fb)
    }
}

class FooWithGenerics {
    def <T extends FooBound> void say(T p) {
    }
}
class FooBound {
}
The following code produces static type checking error:

{code}
import groovy.transform.*

@TypeChecked
class Foo {
    def say() {
        FooWithGenerics f
        FooBound fb
        f.say(fb)
    }
}

class FooWithGenerics {
    def <T extends FooBound> void say(T p) {
    }
}
class FooBound {
}
{code}
Hide
Permalink
Valery Shyshkin added a comment -

To continue with my work, I slightly modified method
StaticTypeCheckingVisitor.parameterizeArguments(). 

parameterizedCN.setGenericsPlaceHolder(paramType.isGenericsPlaceHolder());

for each variable parameterizedCN appearance.

Then modified StaticTypeCheckingSupportMy.isAssignableTo method:

................
................   
if (OBJECT_TYPE.equals(toBeAssignedTo)) return true;
if (toBeAssignedTo.isUsingGenerics()) {
  if ( toBeAssignedTo.isGenericsPlaceHolder() &&   
      toBeAssignedTo.getGenericsTypes() != null) {
      GenericsType gt = toBeAssignedTo.getGenericsTypes()[0];
      return gt.isCompatibleWith(type);
  }
  // perform additional check on generics
  // ? extends toBeAssignedTo
  GenericsType gt = GenericsUtils.buildWildcardType(toBeAssignedTo);
  return gt.isCompatibleWith(type);
}
................
................
Show
Valery Shyshkin added a comment - To continue with my work, I slightly modified method StaticTypeCheckingVisitor.parameterizeArguments(). parameterizedCN.setGenericsPlaceHolder(paramType.isGenericsPlaceHolder()); for each variable parameterizedCN appearance. Then modified StaticTypeCheckingSupportMy.isAssignableTo method: ................ ................ if (OBJECT_TYPE.equals(toBeAssignedTo)) return true ; if (toBeAssignedTo.isUsingGenerics()) { if ( toBeAssignedTo.isGenericsPlaceHolder() && toBeAssignedTo.getGenericsTypes() != null ) { GenericsType gt = toBeAssignedTo.getGenericsTypes()[0]; return gt.isCompatibleWith(type); } // perform additional check on generics // ? extends toBeAssignedTo GenericsType gt = GenericsUtils.buildWildcardType(toBeAssignedTo); return gt.isCompatibleWith(type); } ................ ................
Cedric Champeau made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Cedric Champeau [ melix ]
Fix Version/s 2.0-beta-2 [ 18072 ]
Resolution Fixed [ 1 ]
Paul King made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Cedric Champeau
    Reporter:
    Valery Shyshkin
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: