[#GROOVY-5137] MockFor.getInstance() fails for abstract classes - jira.codehaus.org

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.8.2, 1.8.3, 1.8.4
Fix Version/s: 1.8.5, 2.0-beta-2
Component/s: class generator, mocks and stubs
Labels:
None

Number of attachments :
0

Description

Trying to mock or stub an abstract class fails as of groovy 1.8.2 and later (this
works under 1.7.10, 1.8.0, and 1.8.1). This code

import groovy.mock.interceptor.MockFor

MockFor.getInstance(URLConnection, new URL('http://foo'))

results in

Caught: BUG! exception in phase 'class generation' in source unit 'Script1.groovy' SpreadExpression should not be visited here
BUG! exception in phase 'class generation' in source unit 'Script1.groovy' SpreadExpression should not be visited here

The breakage was possibly introduced by the fix for ~~GROOVY-4968~~.

Also note that this may be related to GROOVY-4255, though I'd expect MockFor and StubFor
to work irrespective of the status of that bug.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Paul King added a comment - 22/Nov/11 11:37 PM

The generated source for the underlying proxy object which works on 1.8.1 but fails from 1.8.2 is the following:

class URLConnection_groovyProxy extends java.net.URLConnection {
    private closureMap
    URLConnection_groovyProxy(map, args) {
        super(*args)
        this.closureMap = map
    }
    void connect() { throw new UnsupportedOperationException()    }
}
new URLConnection_groovyProxy(map, constructorArgs)

Show

Paul King added a comment - 22/Nov/11 11:37 PM The generated source for the underlying proxy object which works on 1.8.1 but fails from 1.8.2 is the following: class URLConnection_groovyProxy extends java.net.URLConnection { private closureMap URLConnection_groovyProxy(map, args) { super (*args) this .closureMap = map } void connect() { throw new UnsupportedOperationException() } } new URLConnection_groovyProxy(map, constructorArgs)

Hide

Permalink

Cedric Champeau added a comment - 23/Nov/11 11:17 AM

Bisecting leads to the following commit:

~/DEV/PROJECTS/OPENSOURCE/GROOVY/groovy-git/groovy-git (git::(no branch)) $ git bisect good
71feea7cb3adb91c7eaae766932a8980947c208d is the first bad commit
commit 71feea7cb3adb91c7eaae766932a8980947c208d
Author: Jochen <blackdrag@gmx.org>
Date:   Mon Aug 29 17:53:08 2011 +0200

    GROOVY-4559: enable more direct super constructor calls

Show

Cedric Champeau added a comment - 23/Nov/11 11:17 AM Bisecting leads to the following commit: ~/DEV/PROJECTS/OPENSOURCE/GROOVY/groovy-git/groovy-git (git::(no branch)) $ git bisect good 71feea7cb3adb91c7eaae766932a8980947c208d is the first bad commit commit 71feea7cb3adb91c7eaae766932a8980947c208d Author: Jochen <blackdrag@gmx.org> Date: Mon Aug 29 17:53:08 2011 +0200 GROOVY-4559: enable more direct super constructor calls

MockFor.getInstance() fails for abstract classes

Details

Description

Activity

People

Dates