Named parameter support breaks with postgres casting syntax

In groovy.sql.Sql changing:

private static final Pattern NAMED_QUERY_PATTERN = Pattern.compile("(?::|\\?(\\d?)\\.?)(\\w*)");

to:

private static final Pattern NAMED_QUERY_PATTERN = Pattern.compile("(?<!:)(:|\\?(\\d*)\\.)(\\w+)");

should fix this problem. It matches:

:foo 
?.bar 
?1.baz 
?12.baz

but not:

:
::asdf

It does not cover the case when something that looks like a named parameter is contained in a string e.g:

select * from some_table where description = ':notANamedParameter'

This case is probably hard to cover in a regex as it must check that it is not a named parameter surrounded by strings e.g.:

':notANamedParameter' :aNamedParameter ':alsoNotANamedParameter'

So while this is not a perfect solution it adds functionality without removing any (as far as I can tell).

@Lucian, try setting enableNamedQueries=false.

@David, that looks close. We need to also support ordinal (non-named) params and we currently cover both cases with a single regex, so we need to support ?1 for instance. I have adapted your proposed solution and all tests pass - I will commit once I have a good test case.

@Paul, Thanks for the suggestion. Unfortunately it's been a while since I was working on this project and I'm rather snowed under with another project in a completely different environment... I can't remember off the top of my head whether we needed named parameter support or not, but I suspect we might have been able to work around it like that...

changed as per the suggestion (thanks) with some minor changes