groovy

[PATCH] AstBuilderFromSpecificationTest.testElvisOperatorExpression() fails

Details

  • Type: Test Test
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: ast builder
  • Labels:
    None
  • Environment:
    1.9.0-beta-4-SNAPSHOT
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

AstBuilderFromSpecificationTest.testElvisOperatorExpression() fails because it generates AST of 

name ?: 'Anonymous'

but it sets AST of the following as the expected result: 

((boolean) name)?: 'Anonymous'

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guillaume Laforge added a comment -

A script like

var name = "foo"
name ?: "unknown"

generates the AST structure that is used in the current test case.
The test is passing as it is and reflects that structure.
Applying the patch make the test fail, on the contrary.

Show
Guillaume Laforge added a comment - A script like var name = "foo" name ?: "unknown" generates the AST structure that is used in the current test case. The test is passing as it is and reflects that structure. Applying the patch make the test fail, on the contrary.
Hide
Permalink
Masato Nagai added a comment - - edited

Sorry, I had misunderstood. The problem is that the DSL and the expected AST are both incorrect, even though the test passes. 

name ?: 'Anonymous'

generates AST like the following:

new ElvisOperatorExpression(
    new VariableExpression('name'),
    new ConstantExpression('Anonymous')
)

I attached the correct patch, "testElvisOperatorExpression.patch.2".

Show
Masato Nagai added a comment - - edited Sorry, I had misunderstood. The problem is that the DSL and the expected AST are both incorrect, even though the test passes. name ?: 'Anonymous' generates AST like the following: new ElvisOperatorExpression( new VariableExpression('name'), new ConstantExpression('Anonymous') ) I attached the correct patch, "testElvisOperatorExpression.patch.2".
Hide
Permalink
Pascal Schumacher added a comment -

@Guillaume: Can you comment on Nagais last comment?

Show
Pascal Schumacher added a comment - @Guillaume: Can you comment on Nagais last comment?

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    Masato Nagai
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: