groovy

[PATCH] AstBuilderFromSpecificationTest.testFieldExpression sets an incorrect modifier to FieldNode

Details

  • Type: Test Test
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.9-beta-4, 1.8.4
  • Component/s: ast builder
  • Labels:
    None
  • Environment:
    1.9.0-beta-4-SNAPSHOT
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The code try to set the modifier to "public static" but 

ACC_PUBLIC & ACC_STATIC

means NOTHING:

    public void testFieldExpression() {
        // public static String foo = "a value"
        def result = new AstBuilder().buildFromSpec {
            field {
                fieldNode "foo", ACC_PUBLIC & ACC_STATIC, String, this.class, {
                    constant "a value"
                }
            }
        }

Activity

Ascending order - Click to sort in descending order
Guillaume Laforge made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.8.4 [ 17852 ]
Fix Version/s 1.9-beta-4 [ 17656 ]
Resolution Fixed [ 1 ]
Paul King made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    Masato Nagai
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: