Reduce groovyc command line length

Just had a look at the patch, and it seems to still need a bit of work, as it's failing the Groovy build!

Have you tried running the Groovy build with your patch?

-stagedcompile-groovy:
  [groovyc] Compiling 183 source files to /Users/glaforge/Projects/groovy/groovy-git/target/classes
  [groovyc] Exception in thread "main" java.lang.NoClassDefFoundError: org/codehaus/groovy/tools/FileSystemCompiler
  [groovyc] Caused by: java.lang.ClassNotFoundException: org.codehaus.groovy.tools.FileSystemCompiler
  [groovyc] 	at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
  [groovyc] 	at java.security.AccessController.doPrivileged(Native Method)
  [groovyc] 	at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
  [groovyc] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
  [groovyc] 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
  [groovyc] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:247)

BUILD FAILED
/Users/glaforge/Projects/groovy/groovy-git/build.xml:176: The following error occurred while executing this line:
/Users/glaforge/Projects/groovy/groovy-git/build.xml:183: Forked groovyc returned error code: 1

No, sorry. As I said, I wrote it blind.

The change compiled in Eclipse, and I inserted the resulting .class file into my groovy-all jar. Gross hack. But working.

I won't contest that the patch may break things for you. But It's strange that the error cause should be FileSystemCompiler, which is not mentioned in my patch!?!?

Anyway, I'll be happy to set up a properly building Groovy environment locally, and see if I can fix the problem.
Unfortunately, I cannot commit to a deadline for this...

I now have access to a Linux box at work, and on that I get the exact same output as you when using groovyc.

So I'll give it another look.

The problem turned out to simply be "classpath" that should be upper-cased.

Then it works for me on both Windows and Linux.

I tried to build 1.7.10, but it failed with some missing dependencies. So I still did not test it with an actual Groovy build. Sorry.

I've applied the patch to a locally built Groovy 1.8.5 and it solves the problem where the combination of Windows + Gradle + Groovy + Spock fails on my multi-project build with the command line length problem - http://forums.gradle.org/gradle/topics/gradle_groovy_spock_windows_argh

Is a Windows environment such a rarity that this problem is not a bigger issue?

@Steven: you applied the patch as is or with the "upper-casing" amendment as well?

Double checking the code, I've added the patch as-is with the lowercase 'classpath' which seems to work on XP at least. I assume this is a *nix/Windows issue with the case of 'classpath' being significant. I manually applied the changes as the patch doesn't match up with the 1.8.5 version of the class. I used the Gradle build to generate the JAR files (though the docs.gradle file is corrupted with diff markers).

I'm only using this custom version as part of the build, so I'm not too concerned about the fitness of the solution, but I would appreciate an official version in the not too distant future.

The patch has been applied with the lowercase "classpath" variation. Leaving open for a brief time while some more testing takes place.

Groovy 1.8.6 still fails for me on the groovyc Ant task. Looking at the source code, it appears that the patch was partially applied as I don't see the removal of lines 782 & 783 from groovyc.java in the Github history.

My apologies, the auto-patch didn't work for me and I applied it manually and somehow I missed those two lines. That's what I get for skimping out on some kind of integration test. Will fix it now.

ok, hopefully this time!