VeryifyError in multi-dimensional array usage: Incompatible argument to function

Chris added a comment - 06/Aug/11 9:11 AM Sorry, this error is not present in 1.8.0, I forgot to recompile after changing the gdk. It does remain in 1.8.1, however.

Roshan Dawrani added a comment - 06/Aug/11 10:12 PM Here is a shorter piece of code that reproduces it: char [] c1 = 'xy'.toCharArray() getIndex(c1[0]) /* //Note: This works fine char a = 'a' getIndex(a) */ def getIndex( char base) {}

Roshan Dawrani added a comment - 28/Nov/11 9:57 PM Corrected the bug title a bit.

Roshan Dawrani added a comment - 28/Nov/11 10:02 PM Here is the shorter version of the code that currently reproduces the bug. (Probably the shorter version supplied earlier resulted in a VerifyError due to some other reason, and that piece of code works now.) class ParalinearTest { static void main(args){} void zeroMatrix( int [][] matrix) { matrix[0][0] } } The bug can be seen in action on Groovy Web Console here: http://groovyconsole.appspot.com/edit/597001

Roshan Dawrani added a comment - 28/Nov/11 10:14 PM The VerifyError is caused by how multi-dimensional arrays are handled on the fast-path. For "int[][] matrix", matrix [0] [0] is written in the class like: BytecodeInterface8.intArrayGet(BytecodeInterface8.objectArrayGet(matrix, 0), 0) when it should have been written as: BytecodeInterface8.intArrayGet(( int [])ScriptBytecodeAdapter.castToType(BytecodeInterface8.objectArrayGet(matrix, 0), int []), 0) The result of BytecodeInterface8.objectArrayGet was not casted to int[], which made the BytecodeInterface8.intArrayGet() call invalid. The following patch solves the issue (tested locally with the latest shorter version and the original testcase of the bug): @@ -166,11 +166,15 @@ public class BinaryExpressionMultiTypeDispatcher extends BinaryExpressionHelper leftExp.visit(acg); os.doGroovyCast(leftTypeOrig); rightExp.visit(acg); os.doGroovyCast(int_TYPE); bew.arrayGet(operation, false ); - os.replace(leftType,2); + if (bew instanceof BinaryObjectExpressionHelper) { + os.replace(ClassHelper.OBJECT_TYPE,2); + } else { + os.replace(leftType,2); + } } else { super .evaluateBinaryExpression(message, binExp); } } else { int operationType = getOperandConversionType(leftType,rightType);

blackdrag blackdrag added a comment - 29/Nov/11 6:45 AM Well spotted Roshan! If that patch works with a 3d and 4d array too, then it would be nice of you to commit it. But I think it will work

Roshan Dawrani added a comment - 29/Nov/11 9:42 PM Extended the test to cover 3d, 4d arrays also. They also work now.