groovy

Groovy Console Icon for OSX still broken

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.1
  • Fix Version/s: 1.8.2, 1.9-beta-3, 1.7.11
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

The long serving bug GROOVY-4306 is still around.

Looking at the icns file using a hex editor (and comparing it to the one I attached to the GROOVY-4306 issue) seems to show lots of extra data being stuffed into the one distributed with the binary distribution...

It's like it's being converted to unicode or something?

The original icns file starts with the following 64 bytes:

69636E73 0001B17B 696C3332 00000A51
87FF0B53 2D110A05 0B0A0B0C 1E38EC8F
FF10551A 13294760 717A7F73 6948270B
2595C08A FF147F23 1C45718A 9EABB1B4

But the distributed one starts with:

69636E73 0001EFBF BD7B696C 33320000
0A51EFBF BDEFBFBD 0B532D11 0A050B0A
0B0C1E38 EFBFBDEF BFBD1055 1A132947
60717A7F 73694827 0B25EFBF BDEFBFBD

As you can see, the byte B1 at position 7 in the original has been changed to EFBFBD in the distributed file – and again, 87FF at position 16 seems to be replaced with EFBFBDEFBFBD

The file size has increased as well, the original being 110971 bytes in length, but the distributed file is 214052 bytes

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guillaume Laforge added a comment -

Rohhh... okay, so it was really not a problem with fixcrlf...
I don't think we have a native2ascii call or something like that though.
Not sure what borks the icon file yet

Show
Guillaume Laforge added a comment - Rohhh... okay, so it was really not a problem with fixcrlf... I don't think we have a native2ascii call or something like that though. Not sure what borks the icon file yet
Hide
Permalink
Tim Yates added a comment -

Strangely, if I run ant dist on my mac, and unzip the generated target/dist/groovy-binary-1.9.0-beta-2-SNAPSHOT.zip file, the bin/groovy.icns file inside is fine

My current guesses are:

  1. Something downstream from here, between building and releasing to the site for download is manipulating the file
  2. The machine that builds the distribution has some extra steps it performs which is corrupting the file
  3. Building on a non-mac machine corrupts the file
  4. Building on Java 1.5 or an ant version < 1.8.2 corrupts the file

But they are only guesses, and I have no way to check if any of them are true

Show
Tim Yates added a comment - Strangely, if I run ant dist on my mac, and unzip the generated target/dist/groovy-binary-1.9.0-beta-2-SNAPSHOT.zip file, the bin/groovy.icns file inside is fine My current guesses are: Something downstream from here, between building and releasing to the site for download is manipulating the file The machine that builds the distribution has some extra steps it performs which is corrupting the file Building on a non-mac machine corrupts the file Building on Java 1.5 or an ant version < 1.8.2 corrupts the file But they are only guesses, and I have no way to check if any of them are true
Hide
Permalink
Tim Yates added a comment -

Just did a quick search for EFBFBD, and it looks like it is the Unicode Replacement Character

used to replace an incoming character whose value is unknown or unrepresentable in Unicode

So it is something somewhere checking that groovy.icns is valid unicode (which it obviously isn't), and injecting replacement chars all over the place

Show
Tim Yates added a comment - Just did a quick search for EFBFBD , and it looks like it is the Unicode Replacement Character used to replace an incoming character whose value is unknown or unrepresentable in Unicode So it is something somewhere checking that groovy.icns is valid unicode (which it obviously isn't), and injecting replacement chars all over the place
Hide
Permalink
blackdrag blackdrag added a comment -

The ant copy task we used here changed the file. We fixed that now and it seems the file is now unchanged copied over, which should fix the problem

Show
blackdrag blackdrag added a comment - The ant copy task we used here changed the file. We fixed that now and it seems the file is now unchanged copied over, which should fix the problem

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    Tim Yates
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: