groovy
  1. groovy
  2. GROOVY-4912

Make the createLoggingStrategy method protected, otherwise LogASTTransformation is not extensible

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.8.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Activity

      Hide
      blackdrag blackdrag added a comment -

      LogASTTransformation is not designed to be extensible. Instead you are supposed to use an annotation, that provides its logging strategy as class value to the log setting and by implementing LogASTTransformation.LoggingStrategy. This class is then used by createLoggingStrategy to create the strategy. An example for that is the Log4j annotation in the same package as LogASTTransformation.

      Can you explain a little what kind of extension you have in mind?

      Show
      blackdrag blackdrag added a comment - LogASTTransformation is not designed to be extensible. Instead you are supposed to use an annotation, that provides its logging strategy as class value to the log setting and by implementing LogASTTransformation.LoggingStrategy. This class is then used by createLoggingStrategy to create the strategy. An example for that is the Log4j annotation in the same package as LogASTTransformation. Can you explain a little what kind of extension you have in mind?
      Hide
      Pascal Schumacher added a comment -

      Should this issue be closed?

      Show
      Pascal Schumacher added a comment - Should this issue be closed?
      blackdrag blackdrag made changes -
      Field Original Value New Value
      Resolution Won't Fix [ 2 ]
      Status Open [ 1 ] Resolved [ 5 ]
      Assignee blackdrag blackdrag [ blackdrag ]
      Paul King made changes -
      Status Resolved [ 5 ] Closed [ 6 ]

        People

        • Assignee:
          blackdrag blackdrag
          Reporter:
          Graeme Rocher
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: