groovy

groovy.bat fails when the JAVA_OPTS contains space characters

Details

  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

groovy.bat fails when the JAVA_OPTS environment variable contains space characters like the following:

> set JAVA_OPTS=-Daprop="a value"
> bin\groovy -h
value"" was unexpected at this time.

  1. File
    patch
    02/Jul/11 6:04 AM
    2 kB
    Masato Nagai
  2. File
    test.groovy4910.bat
    03/Jul/11 8:01 AM
    0.6 kB
    Masato Nagai

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Masato Nagai added a comment -

>contains space characters
contains double quoted strings have space characters

Show
Masato Nagai added a comment - >contains space characters contains double quoted strings have space characters
Hide
Permalink
Masato Nagai added a comment -

When JAVA_OPTS is -Daprop="a value", "%JAVA_OPTS" means "-Daprop="a value"".
So the following part of startGroovy.bat (line 223) throws the error.

if "%JAVA_OPTS%" == "" set JAVA_OPTS="-Xmx128m"

The patch changes startGroovy.bat to use GROOVY_OPTS local variable for local options instead of JAVA_OPTS that is commonly used by other programs.

Show
Masato Nagai added a comment - When JAVA_OPTS is -Daprop="a value", "%JAVA_OPTS" means "-Daprop="a value"". So the following part of startGroovy.bat (line 223) throws the error. if "%JAVA_OPTS%" == "" set JAVA_OPTS="-Xmx128m" The patch changes startGroovy.bat to use GROOVY_OPTS local variable for local options instead of JAVA_OPTS that is commonly used by other programs.
Hide
Permalink
Masato Nagai added a comment -

I also attached a small test program.
By the way, is there nobody can verify this issue?

Show
Masato Nagai added a comment - I also attached a small test program. By the way, is there nobody can verify this issue?
Masato Nagai made changes -
Field Original Value New Value
Attachment test.groovy4910.bat [ 55851 ]
Hide
Permalink
blackdrag blackdrag added a comment -

Paul, can you check this?

Show
blackdrag blackdrag added a comment - Paul, can you check this?
blackdrag blackdrag made changes -
Assignee Paul King [ paulk ]
Paul King made changes -
Component/s command line processing [ 10445 ]
Hide
Permalink
Paul King added a comment -

patch applied, thanks

Show
Paul King added a comment - patch applied, thanks
Paul King made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.8.2 [ 17495 ]
Fix Version/s 1.9-beta-2 [ 17494 ]
Resolution Fixed [ 1 ]
Paul King made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Paul King
    Reporter:
    Masato Nagai
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: