Calling a method overwritten via metaClass from another method uses the original (non-overwritten) method

Oddly, works as expected on the Groovy Web Console (which I believe is running 1.8.0?)...

Groovy Web Console indeed runs 1.8.0.

We appear to be hitting this in our tests... Upgrading from 1.7.5 to 1.8.0 broke tests that verified values by overriding m1()-type methods and checking what m2() was passing in.

We've tried the 1.8.1 snapshot, but our tests still fail.

I'd be happy to attach an example, but it doesn't vary much from Rene's code. Please let me know if there's anything I can do to help!

Hi Jochen,

Rene's example works, and more of our tests pass with 1.8.1, but we're still having problems with what looks like a variant of the problem.

This is a stripped-down version of a test that passes with 1.7.6 but fails with 1.8.1:

import org.junit.Test;

public class BreakingExample_NoMetaclassOverride {
   @Test
   void testNotOverriden() {
      def list = []
      ClassUnderTest cut = new ClassUnderTest()
      cut.metaClass.getRemoteObject = { ->
         return [method: {obj -> 
            list << obj
         }] as RemoteObject
      }
      
      String val = "Value" 
      cut.someMethod(val)
      assert list == [val]
   }
}

public class ClassUnderTest {
   public def someMethod(String someValue) {
      RemoteObject object = getRemoteObject()
      object.method(someValue)
   }
   protected RemoteObject getRemoteObject() {
      return new RemoteObject()
   }
}

public class RemoteObject {
   public void method(obj) { /* Something */ }
}

Is this a bug or a change in how the metaClass works?

Thank you!
Jason

your code works for me in trunk.

Seems we either need another issue to track the fix into 1.8.x or re-open this issue. If it's not appropriate to re-open this, we can make a new report for the problem Jason identified in 1.8.1.

please open a new issue

Looks like Eclipse and/or I messed up the build order... The Groovy-Eclipse plugin (currently) comes with Groovy 1.8.0. Once I made sure I had groovy-all-1.8.1.jar ahead of "Groovy Libraries" in the Order and Export list, the example I posted worked.

The test it came from still fails in Eclipse, but that looks like further Eclipse wackiness... The failing test passes by cleaning, building and testing from command-line Ant using only 1.8.1.

Thanks for taking a look, Jochen!