groovy

@WithReadLock and @WithWriteLock creates the wrong locks

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8-rc-4
  • Fix Version/s: 1.8.0, 1.9-beta-1
  • Component/s: Compiler
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    0

Description

The @WithReadLock forces a method to obtain a write lock.
The @WithWriteLock forces a method to obtain a read lock.

This is exactly backwards. It should be the other way around. I have a fix.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hamlet D'Arcy added a comment -

fixed.

Show
Hamlet D'Arcy added a comment - fixed.
Hide
Permalink
Guillaume Laforge added a comment -

Fixed on which branches? Shouldn't it be fixed on 1_8_X, trunk, but also 1_8_RC?

Show
Guillaume Laforge added a comment - Fixed on which branches? Shouldn't it be fixed on 1_8_X, trunk, but also 1_8_RC?
Hide
Permalink
Hamlet D'Arcy added a comment -

I checked it into 1_8_x and trunk. I was under the impression that it was too late for 1_8_RC.

Show
Hamlet D'Arcy added a comment - I checked it into 1_8_x and trunk. I was under the impression that it was too late for 1_8_RC.
Hide
Permalink
Paul King added a comment -

Anything for RC branch should be discussed as anything major would require another RC, i.e. RC-5. I chatted to Guillaume and Jochen about ReadWriteLockASTTransformation and we think it is fine for RC so I merged it onto that branch. I remove the early return (one line above your change) as otherwise the Runtime exception would never be in play.

Show
Paul King added a comment - Anything for RC branch should be discussed as anything major would require another RC, i.e. RC-5. I chatted to Guillaume and Jochen about ReadWriteLockASTTransformation and we think it is fine for RC so I merged it onto that branch. I remove the early return (one line above your change) as otherwise the Runtime exception would never be in play.

People

  • Assignee:
    Hamlet D'Arcy
    Reporter:
    Hamlet D'Arcy
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: