Standalone stub generation task fails resolving classes

but joint compilation using groovyc works, or not?

Since no other information is provided, if I just try:

Foo.java

class Foo {}

and Bar.groovy:

class Bar extends Foo {}

and compile as

groovyc *

then the joint compilation goes through just fine (using groovy 1.7.5).

With groovyc 1.7.8, it works too.

The problem is that we need stub generation as a separate step, our (IntelliJ IDEA) build is a quite complex process, it consists of many stages and stub generation and javac/groovyc happen to be on different stages.

The joint compilation works indeed, because the stub generation there happens twice: once during conversion and the other time during semantic analysis. The stub generated in conversion gets immediately compiled by Javac (see JavaAwareCompilationUnit), and so it is available for resolve during the semantic analysis. In a separate standalone stub generator (GenerateStubsTask, JavaStubCompilationUnit) semantic analysis also happens, but nobody has generated and compiled the stubs together with the Java sources before that, so the resolve fails.

Peter, perhaps you could explain a bit more concretely what you would like to see? What would help IntelliJ IDEA? That everything runs in CONVERSION phase, or something like that?

It would help if the resolve process didn't fail the compilation. This can be achieved by making the standalone stub generation not run it (i.e. to work only up to the conversion phase) or just ignore the unresolved references during the semantic analysis. The first alternative means even wider gap between joint compilation and just stub generation, the second one looks a bit like a hack. But both would work for us.

I attached a patch. It aligns the stub task with our joint compilation more in such that it moves the stub generation to the conversion phase and also does the VariableScopeVisitor and JavaAwareResolveVisitor runs before. Since this is a bigger change to the stub generator task we will include that only after 1.8.0

But before this can be really included we absolutely need some tests I think

Peter if you would test that patch it would surely help us

Jochen,

Unfortunately I don't have much time now to build Groovy and try it, but from the first shallow glance the patch looks good. And I'd include this into 1.7.x for the following reason: JavaStubCompilationUnit is used only from the commented out generatestubs task, and currently this will definitely fail (when doing clean build) when there's at least one Groovy file referencing at least one Java class. As no one but me came with this problem, I assume we're the only clients of this task. So nothing should break except possibly for us, which in turn shouldn't happen. And I agree that having a test would be great.

Peter, sorry for not appllying the patch earlier, now it is done.