groovy

Improve FactoryBuilderSupport exception messages

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.8-rc-2, 1.9-beta-1
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    0

Description

FactoryBuilderSupport exception messages could be improved in checkValueIsType() and checkValueIsTypeNotString().

Today the messages read: "The value of argument 'foo' must be of type Bar."
This doesn't tell the user what the input was that caused the failure.
A better message is: "The value of argument 'foo' must be of type Bar. Found: Baz"

This is an easy change to make, and cannot cause a NPE or anything like that.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hamlet D'Arcy added a comment -

Should this be rolled back to 1.8 or 1.7?

Show
Hamlet D'Arcy added a comment - Should this be rolled back to 1.8 or 1.7?
Hide
Permalink
Hamlet D'Arcy added a comment -

Fixed in the head (1.9)

Show
Hamlet D'Arcy added a comment - Fixed in the head (1.9)
Hide
Permalink
Guillaume Laforge added a comment -

Yes, this bug fix can be backported too.
Value cannot be null? (calling getClass() on null would throw NPE)

Show
Guillaume Laforge added a comment - Yes, this bug fix can be backported too. Value cannot be null? (calling getClass() on null would throw NPE)
Hide
Permalink
Hamlet D'Arcy added a comment -

rolled back to 1.8rc2

Show
Hamlet D'Arcy added a comment - rolled back to 1.8rc2

People

  • Assignee:
    Hamlet D'Arcy
    Reporter:
    Hamlet D'Arcy
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
30m
Original Estimate - 30 minutes
Remaining:
30m
Remaining Estimate - 30 minutes
Logged:
Not Specified
Time Spent - Not Specified