groovy

@Field variable can't be referred from closure

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8-rc-1
  • Fix Version/s: 1.8-rc-4
  • Component/s: None
  • Labels:
    None
  • Environment:
    Mac OS X
  • Number of attachments :
    2

Description

attached code 

import groovy.transform.Field

@Field def xxx = 3

foo = {
  println xxx
}

foo()

generate following error:

Caught: BUG! exception in phase 'class generation' in source unit '/Users/uehaj/tmp/bug.groovy' tried to get a variable with the name xxx as stack variable, but a variable with this name was not created

  1. File
    bug.groovy
    28/Feb/11 8:34 AM
    0.1 kB
    UEHARA Junji
  2. Text File
    Fixed_GROOVY-4700.patch
    29/Mar/11 11:06 AM
    6 kB
    Cedric Champeau

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Cedric Champeau added a comment -

The following patch (with tests) fixes this issue

Show
Cedric Champeau added a comment - The following patch (with tests) fixes this issue
Hide
Permalink
Paul King added a comment - - edited

Cédric's patch looks good to me. Applied in trunk. I also think it is a serious enough bug to warrant merging into 1.8 RC4 but will await Guillaume and Jochen's review/comments.

Show
Paul King added a comment - - edited Cédric's patch looks good to me. Applied in trunk. I also think it is a serious enough bug to warrant merging into 1.8 RC4 but will await Guillaume and Jochen's review/comments.
Hide
Permalink
Cedric Champeau added a comment -

Thanks Paul. I looked at your commit, and you accidently changed a test case : in testFieldShouldBeAccessibleFromClosureWithoutAssignment, you added an assignment to 

foo  = { ... }

, adding a "def" which changes the BinaryExpression into a DeclarationExpression. I think it's important to test both, because I had a fix that only dealt with the DeclarationExpression first and it didn't work with the BinaryExpression, that is to say the script which is attached as a proof for this bug

Show
Cedric Champeau added a comment - Thanks Paul. I looked at your commit, and you accidently changed a test case : in testFieldShouldBeAccessibleFromClosureWithoutAssignment , you added an assignment to foo = { ... } , adding a "def" which changes the BinaryExpression into a DeclarationExpression . I think it's important to test both, because I had a fix that only dealt with the DeclarationExpression first and it didn't work with the BinaryExpression , that is to say the script which is attached as a proof for this bug
Hide
Permalink
Paul King added a comment -

well the change was deliberate but the consequence was not so I changed it back

Show
Paul King added a comment - well the change was deliberate but the consequence was not so I changed it back
Hide
Permalink
Guillaume Laforge added a comment -

I think that would be good in 1.8 too.
We'll have to release an RC-4.

Show
Guillaume Laforge added a comment - I think that would be good in 1.8 too. We'll have to release an RC-4.
Hide
Permalink
Paul King added a comment -

merged in preparation for RC4. Thanks to everyone involved.

Show
Paul King added a comment - merged in preparation for RC4. Thanks to everyone involved.

People

  • Assignee:
    Paul King
    Reporter:
    UEHARA Junji
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: