groovy

anonymous classes InnerClassNode has -1 for line numbers

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.8-rc-2, 1.7.9, 1.9-beta-1
  • Component/s: Compiler
  • Labels:
    None
  • Number of attachments :
    1

Description

anonymous classes InnerClassNode has -1 for line numbers

new Object() {}

produces an InnerCLassNode. The lineNUmbers are -1

This affects CodeNarc. I'd love to see this rolled back as far as possible. To 1.8 surely.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Cedric Champeau added a comment -

Patch fixes this issue.

Show
Cedric Champeau added a comment - Patch fixes this issue.
Hide
Permalink
Hamlet D'Arcy added a comment -

thanks for the Patch Cédric. This type of thing should be easily unit tested... I'll write one and check in

Show
Hamlet D'Arcy added a comment - thanks for the Patch Cédric. This type of thing should be easily unit tested... I'll write one and check in
Hide
Permalink
Hamlet D'Arcy added a comment -

applied cédric's patch and wrote a unit test
applied to 1.9.x, 1.8.x, and 1.7.x (just in case there is one more build)

Show
Hamlet D'Arcy added a comment - applied cédric's patch and wrote a unit test applied to 1.9.x, 1.8.x, and 1.7.x (just in case there is one more build)

People

  • Assignee:
    Hamlet D'Arcy
    Reporter:
    Hamlet D'Arcy
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: