groovy

Grails 1.3.7 breaks bean-fields plugin

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.7.10, 1.8-rc-3, 1.9-beta-1
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

After upgrading from grails 1.3.6 to 1.3.7 bean-fields plugin render garbage after every <bean:field> tag:

org.codehaus.groovy.grails.web.pages.GroovyPageOutputStack$GroovyPageProxyWriter@602d9d

See http://grails.1312388.n4.nabble.com/Grails-1-3-7-and-bean-fields-td3311784.html

The sample app attached show the problem in view book/index

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Goran Ehrsson added a comment -

Attached screenshot that shows the extra output after each field.

Show
Goran Ehrsson added a comment - Attached screenshot that shows the extra output after each field.
Hide
Permalink
Goran Ehrsson added a comment - - edited

Since the standard 'grails bug-report' command produces an incomplete zip (GRAILS-7300), I attached a new zip that includes all neccesary files.

Show
Goran Ehrsson added a comment - - edited Since the standard 'grails bug-report' command produces an incomplete zip ( GRAILS-7300 ), I attached a new zip that includes all neccesary files.
Hide
Permalink
Guillaume Laforge added a comment -

Thank you Goran.
I've managed to reproduce the issue by creating a new app and copying the necessary files.
With Jochen, we've narrowed down the changes to Groovy that triggered this problem, by "bisecting" till finding the right commit that was causing the issue.
Interestingly, the commit which was fixing a problem Luke had with his remote closures project, but which covered some other issues that you've been facing.
We found a fix for that already, we'll release another Groovy 1.7 release next week with the fix.

Show
Guillaume Laforge added a comment - Thank you Goran. I've managed to reproduce the issue by creating a new app and copying the necessary files. With Jochen, we've narrowed down the changes to Groovy that triggered this problem, by "bisecting" till finding the right commit that was causing the issue. Interestingly, the commit which was fixing a problem Luke had with his remote closures project, but which covered some other issues that you've been facing. We found a fix for that already, we'll release another Groovy 1.7 release next week with the fix.
Hide
Permalink
Marc Palmer added a comment -

Great work guys, thanks for your efforts on this!

Show
Marc Palmer added a comment - Great work guys, thanks for your efforts on this!
Hide
Permalink
Marc Palmer added a comment -

Guillaume/Jochen can we get some info on the actual problem here to evaluate what other code might be affected?

Show
Marc Palmer added a comment - Guillaume/Jochen can we get some info on the actual problem here to evaluate what other code might be affected?
Hide
Permalink
Guillaume Laforge added a comment -

You can have a look at the commits on the groovy-scm mailing-list, but it won't help you much, and is difficult to know exactly what other impacts it could have.

Show
Guillaume Laforge added a comment - You can have a look at the commits on the groovy-scm mailing-list, but it won't help you much, and is difficult to know exactly what other impacts it could have.
Hide
Permalink
Goran Ehrsson added a comment -

Since no new version of Grails is released we still cannot use the bean-fields plugin.
What do we tell Grails developers on 1.3.7 that want to use bean-fields?
I created an issue for bean-fields here http://jira.grails.org/browse/GPBEANFIELDS-37

Show
Goran Ehrsson added a comment - Since no new version of Grails is released we still cannot use the bean-fields plugin. What do we tell Grails developers on 1.3.7 that want to use bean-fields? I created an issue for bean-fields here http://jira.grails.org/browse/GPBEANFIELDS-37
Hide
Permalink
Guillaume Laforge added a comment -

Users will probably have to wait for a Grails release including Groovy 1.7.10 which fixed the issue.

Show
Guillaume Laforge added a comment - Users will probably have to wait for a Grails release including Groovy 1.7.10 which fixed the issue.

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    Goran Ehrsson
Vote (3)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: