groovy

implement final for local variables

Details

  • Type: Task Task
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 1.8.x, 2.x
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

a final modifier on a local variable of some kind is currently ignored by groovy. Instead groovy should give a compile time error if final is used but the variable gets still a value

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul King added a comment -

Attaching a spike. This is too strict in that it requires initialization at declaration time, e.g. this is correctly detected:

final x = 3
x = 4            // error
(x, y) = [5, 6]  // also an error

but will reject the following valid code:

final x
x = 2
Show
Paul King added a comment - Attaching a spike. This is too strict in that it requires initialization at declaration time, e.g. this is correctly detected: final x = 3 x = 4 // error (x, y) = [5, 6] // also an error but will reject the following valid code: final x x = 2
Paul King made changes -
Field Original Value New Value
Attachment finalForLocalVarsTooStrict.patch [ 55966 ]
Hide
Permalink
Paul King added a comment -

A revised patch handling parameters and only local variables with an initial default value. Some questions in my mind:

  • Should EmptyExpression check be outside VariableExpression
  • Do we need to visit defaultValue in VariableScopeVisitor or VariableExpression
  • Is there a better way rather than pushing defaultValue into VariableExpression
  • Should we be handling multiple assignment cases better
  • And the big TODO of dealing with local variables that don't have an initial expression
Show
Paul King added a comment - A revised patch handling parameters and only local variables with an initial default value. Some questions in my mind: Should EmptyExpression check be outside VariableExpression Do we need to visit defaultValue in VariableScopeVisitor or VariableExpression Is there a better way rather than pushing defaultValue into VariableExpression Should we be handling multiple assignment cases better And the big TODO of dealing with local variables that don't have an initial expression
Paul King made changes -
Attachment finalForParamsAndLocalVarsPartial.patch [ 55996 ]
Attachment astNodeChangesWithFinal.patch [ 55997 ]
Hide
Permalink
Paul King added a comment -

Updated patch - excludes method parameter logic as that is already committed

Show
Paul King added a comment - Updated patch - excludes method parameter logic as that is already committed
Paul King made changes -
Attachment finalForLocalVariables.patch [ 56012 ]
Paul King made changes -
Attachment astNodeChangesWithFinal.patch [ 55997 ]
Paul King made changes -
Attachment finalForLocalVarsTooStrict.patch [ 55966 ]
Paul King made changes -
Attachment finalForParamsAndLocalVarsPartial.patch [ 55996 ]
Hide
Permalink
Paweł Gdula added a comment -

Is there any plan to fix this?

Show
Paweł Gdula added a comment - Is there any plan to fix this?

People

  • Assignee:
    Unassigned
    Reporter:
    blackdrag blackdrag
Vote (4)
Watch (5)

Dates

  • Created:
    Updated: