groovy

static inner classes are not being compiled correctly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.7.6, 1.8-beta-3
  • Fix Version/s: 1.8-rc-1, 1.7.9
  • Component/s: Compiler
  • Labels:
    None
  • Number of attachments :
    0

Description

The groovy compiler used by eclipse & intellij are both having trouble compiling static inner classes. The groovyc compiler does not fail but it appears to generate incorrect bytecode. I filed a issue with intellij and they said that this is a groovy compiler problem not and intellij problem.

The following code triggers the problem:

//groovy code
class Outer {
  static class Inner {}
}

//java code
public class Client {
  { new Outer.Inner(); }
}

This is a serious issue because without any tool support we cannot use static inner classes. The only work around for this issue is to not use static inner classes.

Here are the following issues related to this:

http://jira.codehaus.org/browse/GRECLIPSE-983
http://youtrack.jetbrains.net/issue/IDEA-64752
http://youtrack.jetbrains.net/issue/IDEA-50708

I have not looked in detail at the bytecode generated by the groovy compiler but decompiling the class files with JD Decompiler gives the following:

//notice no reference to the Inner class.  Decompiling a java compiled class like this will show the Inner class in the Outer class.
public class Outer
  implements GroovyObject
{
  public Outer()
  {
    Outer this;
    CallSite[] arrayOfCallSite = $getCallSiteArray();
    MetaClass localMetaClass = $getStaticMetaClass();
    this.metaClass = localMetaClass;
  }

  static
  {
    Long localLong1 = (Long)DefaultTypeTransformation.box(0L);
    __timeStamp__239_neverHappen1296229343062 = DefaultTypeTransformation.longUnbox(localLong1);
    Long localLong2 = (Long)DefaultTypeTransformation.box(1296229343062L);
    __timeStamp = DefaultTypeTransformation.longUnbox(localLong2);
  }
}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Travis added a comment -

Guys, any chance of this being fixed for the 1.8 release?

Show
Travis added a comment - Guys, any chance of this being fixed for the 1.8 release?
Hide
Permalink
blackdrag blackdrag added a comment - - edited

Let's see... If I compile this in java with the public modifier then I get an entry in Outer that looks like this

  // access flags 9
  public static INNERCLASS Outer$Inner Outer Inner

and the same for Inner too. If done with Groovy I see that this inner class reference is missing and the modifier for the inner class is actually 41, meaning that static is set... which is wrong. Since it works without those inner class entries I strongly assume this static flag being set is the major problem here.

Show
blackdrag blackdrag added a comment - - edited Let's see... If I compile this in java with the public modifier then I get an entry in Outer that looks like this // access flags 9 public static INNERCLASS Outer$Inner Outer Inner and the same for Inner too. If done with Groovy I see that this inner class reference is missing and the modifier for the inner class is actually 41, meaning that static is set... which is wrong. Since it works without those inner class entries I strongly assume this static flag being set is the major problem here.
Hide
Permalink
Travis added a comment -

Hey, thanks for the quick response! If there is any way that I can help out with this I'd be glad too. Even if it's just testing or something

Show
Travis added a comment - Hey, thanks for the quick response! If there is any way that I can help out with this I'd be glad too. Even if it's just testing or something
Hide
Permalink
blackdrag blackdrag added a comment -

I answered quick, because I wanted this bug fixed already and then forgot about it... anyway, I have a fixed version of this in trunk now. A nice benefit from fixing the entries is that javac suddenly is much faster in compiling the java files of groovy. I can only assume javac got irritated by the wrong entries or has an optimization for inner classes that could not kick in.

Show
blackdrag blackdrag added a comment - I answered quick, because I wanted this bug fixed already and then forgot about it... anyway, I have a fixed version of this in trunk now. A nice benefit from fixing the entries is that javac suddenly is much faster in compiling the java files of groovy. I can only assume javac got irritated by the wrong entries or has an optimization for inner classes that could not kick in.
Hide
Permalink
Travis added a comment -

Jochen,

Will this be in the next 1.8 release (RC or beta)? I think I heard somewhere that trunk is now considered groovy 1.9

Show
Travis added a comment - Jochen, Will this be in the next 1.8 release (RC or beta)? I think I heard somewhere that trunk is now considered groovy 1.9
Hide
Permalink
blackdrag blackdrag added a comment -

I am closing this issue as the fix is now available in 1.8, 1.9 and 1.7

Show
blackdrag blackdrag added a comment - I am closing this issue as the fix is now available in 1.8, 1.9 and 1.7

People

  • Assignee:
    blackdrag blackdrag
    Reporter:
    Travis
Vote (4)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: