groovy

Project Coin underscore placeholder in numbers

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.9-beta-1
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

the proposal can be found here http://mail.openjdk.java.net/pipermail/coin-dev/2009-April/001628.html

a patch containing the needed changes for this proposal and the binary literals together is attached

  1. Text File
    underscore.patch
    22/Dec/10 7:41 AM
    5 kB
    blackdrag blackdrag
  2. Text File
    underscores1.patch
    17/Mar/11 5:34 AM
    5 kB
    Guillaume Laforge

Issue Links

is related to

New Feature - A new feature of the product, which has yet to be developed. GROOVY-4594 Project Coin binary literals

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guillaume Laforge added a comment -

The initial patch wasn't working as is, so I had to rework it a little, but it seems there's now some grammar ambiguity introduced:

ensureGrammars:
    [antlr] ANTLR Parser Generator   Version 2.7.7 (20060906)   1989-2005
    [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13: warning:lexical nondeterminism between alts 2 and 3 of block upon
    [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13:     k==1:'B','b'
    [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13:     k==2:'0','1'
    [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13:     k==3:<end-of-token>,'.','0','1','D'..'G','I','L','d'..'g','i','l'
    [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13:     k==4:<end-of-token>,'+','-','.','0'..'9','D'..'G','I','L','_','d'..'g','i','l'
Show
Guillaume Laforge added a comment - The initial patch wasn't working as is, so I had to rework it a little, but it seems there's now some grammar ambiguity introduced: ensureGrammars: [antlr] ANTLR Parser Generator Version 2.7.7 (20060906) 1989-2005 [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13: warning:lexical nondeterminism between alts 2 and 3 of block upon [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13: k==1:'B','b' [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13: k==2:'0','1' [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13: k==3:<end-of-token>,'.','0','1','D'..'G','I','L','d'..'g','i','l' [antlr] /Users/glaforge/Projects/groovy/trunk/src/main/org/codehaus/groovy/antlr/groovy.g:4190:13: k==4:<end-of-token>,'+','-','.','0'..'9','D'..'G','I','L','_','d'..'g','i','l'
Hide
Permalink
Guillaume Laforge added a comment -

Ambiguity resolved, as there was a surplus alternation that had not been removed.

Show
Guillaume Laforge added a comment - Ambiguity resolved, as there was a surplus alternation that had not been removed.
Hide
Permalink
Guillaume Laforge added a comment -

Grammar changes from Jochen and added tests by Guillaume, so now we can close the issue.

Show
Guillaume Laforge added a comment - Grammar changes from Jochen and added tests by Guillaume, so now we can close the issue.

People

  • Assignee:
    blackdrag blackdrag
    Reporter:
    blackdrag blackdrag
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: