groovy

VerifyError with nonstatic category references in static methods

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7.6
  • Fix Version/s: 1.7.7, 1.8-beta-4
  • Component/s: class generator, Compiler
  • Labels:
    None
  • Environment:
    wxp sp3, jdk 1.6.0_20, groovy 1.7.6
  • Number of attachments :
    2

Description

when an inner class annotated with @Category is referenced from a static method,
it fails at runtime with a VerifyError

without the @Category annotation it works just fine,
so perhaps its something with the transformation

attached is a simple example

  1. Text File
    GROOVY4584_staticInnerClasses.patch
    21/Dec/10 6:09 AM
    37 kB
    Paul King
  2. File
    innerCategory.groovy
    16/Dec/10 9:07 AM
    0.5 kB
    Pertino Juan

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul King added a comment -

proposed patch attached

Show
Paul King added a comment - proposed patch attached
Hide
Permalink
Paul King added a comment -

InnerClassVisitor performed numerous functions including adding some default methods like propertyMissing to the inner class. This was done before the @Category transform was run even though this aspect of InnerClassVisitor's functionality didn't need to be this early in the compiler phases. The @Category transform was turning these into static methods which broke the intended functioning of those methods. So InnerClassVisitor was split into two. Adding the default methods is now done at the end of the Canonical phase of the compiler.

Show
Paul King added a comment - InnerClassVisitor performed numerous functions including adding some default methods like propertyMissing to the inner class. This was done before the @Category transform was run even though this aspect of InnerClassVisitor 's functionality didn't need to be this early in the compiler phases. The @Category transform was turning these into static methods which broke the intended functioning of those methods. So InnerClassVisitor was split into two. Adding the default methods is now done at the end of the Canonical phase of the compiler.
Hide
Permalink
Pertino Juan added a comment -

groovy's internals are still obscure to me,
but i imagined something like that might be happening
thanks for the explanation (and the fix of course, latest 1.7.x snapshot is working for me)

Show
Pertino Juan added a comment - groovy's internals are still obscure to me, but i imagined something like that might be happening thanks for the explanation (and the fix of course, latest 1.7.x snapshot is working for me)

People

  • Assignee:
    Paul King
    Reporter:
    Pertino Juan
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: