groovy

A few UI issues in AST Browser

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8-beta-3
  • Fix Version/s: 1.7.6, 1.8-beta-3
  • Component/s: ast builder
  • Labels:
    None
  • Number of attachments :
    0

Description

In AST Browser UI, if I change some parameters like Show Script flag (free form/class form) or Compile Phase and then press Refresh

1) There is no proper progress indicator of the work that is happening in the background in the non-UI threads. The hourglass also appears if I move the mouse on the small area that shows the AST tree. In most of the remaining screen, mouse pointer looks normal. A progress indicator is needed.

2) As soon as the refresh is pressed, the tree and property tables can be cleared as they take time to get populated and decompiled data comes up very fast and they look out-of-sync till the whole work is completed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hamlet D'Arcy added a comment -

For issue 1 - This is correct behavior... the component that is loading has an hourglass but not the full window. The decompiler runs a lot faster than the tree view, so the decompiler comes up quick and you can work with it. This feature needs to remain in the browser. But you are correct... somehow the Loading message disappeared and we need to put a progress bar or loading tree node back in.

It would be possible to create a progress bar based on the number of methods in every class in the AST, and then tick the progress bar forward once each time the ScriptToTreeNodeAdapter finds a method.

Show
Hamlet D'Arcy added a comment - For issue 1 - This is correct behavior... the component that is loading has an hourglass but not the full window. The decompiler runs a lot faster than the tree view, so the decompiler comes up quick and you can work with it. This feature needs to remain in the browser. But you are correct... somehow the Loading message disappeared and we need to put a progress bar or loading tree node back in. It would be possible to create a progress bar based on the number of methods in every class in the AST, and then tick the progress bar forward once each time the ScriptToTreeNodeAdapter finds a method.
Hide
Permalink
Roshan Dawrani added a comment -

Probably there is no need to come up with some complicated progress bar technique. Just a "Loading AST" message will be enough. Right now "loading" message is not correctly placed because the decompiler area gets refreshed much faster while most of the work is still going on.

In http://groovyastbrowser.appspot.com/, as soon as refresh is pressed, I clear the AST in the tree and put a root node there that says "Loading"..may be something like that or a status bar message that remains there till the whole "refresh" operation is complete.

Show
Roshan Dawrani added a comment - Probably there is no need to come up with some complicated progress bar technique. Just a "Loading AST" message will be enough. Right now "loading" message is not correctly placed because the decompiler area gets refreshed much faster while most of the work is still going on. In http://groovyastbrowser.appspot.com/ , as soon as refresh is pressed, I clear the AST in the tree and put a root node there that says "Loading"..may be something like that or a status bar message that remains there till the whole "refresh" operation is complete.
Hide
Permalink
Roshan Dawrani added a comment -

The AST data population in the tree/table is very inconsistent. 9 out of 10 times, it is still remaining empty. I have waited for minutes for the worker threads to "suddenly" come

Show
Roshan Dawrani added a comment - The AST data population in the tree/table is very inconsistent. 9 out of 10 times, it is still remaining empty. I have waited for minutes for the worker threads to "suddenly" come
Hide
Permalink
Roshan Dawrani added a comment -

Hamlet, since the AST controls are still not correctly getting populated most of the times, and you are working on it, I am moving the issue to your name.

Show
Roshan Dawrani added a comment - Hamlet, since the AST controls are still not correctly getting populated most of the times, and you are working on it, I am moving the issue to your name.
Hide
Permalink
Hamlet D'Arcy added a comment -

fixed in 1.8

Show
Hamlet D'Arcy added a comment - fixed in 1.8
Hide
Permalink
Hamlet D'Arcy added a comment -

fixing on 1.7 branch

Show
Hamlet D'Arcy added a comment - fixing on 1.7 branch
Hide
Permalink
Hamlet D'Arcy added a comment -

fixing on 1.7 branch

Show
Hamlet D'Arcy added a comment - fixing on 1.7 branch

People

  • Assignee:
    Hamlet D'Arcy
    Reporter:
    Roshan Dawrani
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: