groovy

Verify Error when using wrong enum syntax

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.7.5
  • Fix Version/s: None
  • Component/s: Compiler
  • Labels:
    None
  • Number of attachments :
    0

Description

I've tried to declare an enum and made the mistake to put the constructor before the values:

enum Foo {
  Foo(String str) {}, // first I tried with ; but this got me some other error
  ONE("one"), TWO("two")
}

What got me distracted is that Groovy throws a VerifyError here:

java.lang.VerifyError: (class: Foo, method: <clinit> signature: ()V) Unable to pop operand off an empty stack

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roshan Dawrani added a comment -

Following snippet also reproduces the VerifyError

enum Foo {
    Foo(String str) {}
}
Show
Roshan Dawrani added a comment - Following snippet also reproduces the VerifyError enum Foo { Foo( String str) {} }
Hide
Permalink
Roshan Dawrani added a comment -

And it looks like an enum-grammar issue because instead of getting declared as constructor in both the above examples, Foo gets defined as an enum constant.

Show
Roshan Dawrani added a comment - And it looks like an enum-grammar issue because instead of getting declared as constructor in both the above examples, Foo gets defined as an enum constant.
Hide
Permalink
Paul King added a comment -

the above examples seem to be ok on trunk - should we close this issue?

Show
Paul King added a comment - the above examples seem to be ok on trunk - should we close this issue?
Hide
Permalink
blackdrag blackdrag added a comment -

does it work in 1.7 now as well? I would suggest to at least add a testcase

Show
blackdrag blackdrag added a comment - does it work in 1.7 now as well? I would suggest to at least add a testcase
Hide
Permalink
Paul King added a comment -

Hmmm? I was using below as my testcase in the Groovy Console. But this seems to work even in 1.7.5 so perhaps I am doing something wrong?

enum Bar {
  Bar(String str) {}, // first I tried with ; but this got me some other error
  ONE("one"), TWO("two")
}
enum Foo {
    Foo(String str) {}
}
println 'done'
Show
Paul King added a comment - Hmmm? I was using below as my testcase in the Groovy Console. But this seems to work even in 1.7.5 so perhaps I am doing something wrong? enum Bar { Bar( String str) {}, // first I tried with ; but this got me some other error ONE( "one" ), TWO( "two" ) } enum Foo { Foo( String str) {} } println 'done'
Hide
Permalink
Paul King added a comment - - edited

After recent changes the following:

enum Foo {
  ONE("x") { }  // enum const but note missing constructor
}

produces this compilation error:

java.lang.ExceptionInInitializerError
  ...
Caused by: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: Foo$1(java.lang.String, java.lang.Integer, java.lang.String)
  ...

which, while not a fantastic error message, seems consistent with how Groovy implements enums.

Replacing "ONE" with "Foo" yields the same result.

Replacing the supplied String param with "String str" has the same exception with this cause:

java.lang.ExceptionInInitializerError
  ...
Caused by: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: Foo$1(java.lang.String, java.lang.Integer, null)
  ...

So, perhaps this isn't too bad now?

Incidentally, the code below works (although it may not win many style points):

enum Foo {
  Foo("x") { }          // enum constant also called Foo
  Foo(String str) { }   // constructor of Foo
}
assert Foo.values() == [Foo.Foo]
Show
Paul King added a comment - - edited After recent changes the following: enum Foo { ONE( "x" ) { } // enum const but note missing constructor } produces this compilation error: java.lang.ExceptionInInitializerError ... Caused by: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: Foo$1(java.lang.String, java.lang.Integer, java.lang.String) ... which, while not a fantastic error message, seems consistent with how Groovy implements enums. Replacing "ONE" with "Foo" yields the same result. Replacing the supplied String param with "String str" has the same exception with this cause: java.lang.ExceptionInInitializerError ... Caused by: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: Foo$1(java.lang.String, java.lang.Integer, null) ... So, perhaps this isn't too bad now? Incidentally, the code below works (although it may not win many style points): enum Foo { Foo( "x" ) { } // enum constant also called Foo Foo( String str) { } // constructor of Foo } assert Foo.values() == [Foo.Foo]

People

  • Assignee:
    Unassigned
    Reporter:
    Peter Niederwieser
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: