Generated createCallSiteArray is too big for JVM

Details

  • Patch Submitted:
    Yes

Description

We are using groovy as a DSL engine and we have a script that is 4000 lines long. We've split it up into several methods, but we still receive an error about 'Invalid method Code length 66090 in class file script1280242156093619159538'. I analyzed the generated code and the issue is that the groovy generated method $createCallSiteArray is too big. This is happening because we have over 8000 entries in our call site array. I've implemented a fix where the initialization of the String array for the callsite array is split up over several methods if it would generate code that is too big. (Patch attached) In our preliminary testing, this has resolved our issue.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guillaume Laforge added a comment -

Could you also provide the same patch for Groovy 1.7/1.8?
Or aren't 1.7/1.8 not affected by this?

Show
Guillaume Laforge added a comment - Could you also provide the same patch for Groovy 1.7/1.8? Or aren't 1.7/1.8 not affected by this?
Hide
Permalink
Tom Schneider added a comment -

Fix for 1.7.x branch.

Show
Tom Schneider added a comment - Fix for 1.7.x branch.
Hide
Permalink
Tom Schneider added a comment -

Fix for trunk.

Show
Tom Schneider added a comment - Fix for trunk.
Hide
Permalink
Tom Schneider added a comment -

Definitely still an issue for trunk and 1.7. That's the first thing I checked when I ran across this issue. I've attached patches for both 1.7/trunk.

Show
Tom Schneider added a comment - Definitely still an issue for trunk and 1.7. That's the first thing I checked when I ran across this issue. I've attached patches for both 1.7/trunk.
Hide
Permalink
Guillaume Laforge added a comment -

I've committed those changes on all the branches.
We don't plan to do an 1.6.x release though, but we can potentially build a snapshot if really needed.
So prefer 1.7.
Thanks a lot for the contribution!

Show
Guillaume Laforge added a comment - I've committed those changes on all the branches. We don't plan to do an 1.6.x release though, but we can potentially build a snapshot if really needed. So prefer 1.7. Thanks a lot for the contribution!
Hide
Permalink
Tom Schneider added a comment -

Great! Thanks for applying the patches. We already have our own version of 1.6 with this fix., so we'll probably look at upgrading to 1.7.

Show
Tom Schneider added a comment - Great! Thanks for applying the patches. We already have our own version of 1.6 with this fix., so we'll probably look at upgrading to 1.7.

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    Tom Schneider
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: