groovy

Grapes doesn't handle properties correctly used in the organisation field of a POM.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7.3
  • Fix Version/s: 1.7.4, 1.8-beta-1
  • Component/s: Grape
  • Labels:
    None
  • Environment:
    Linux laptop 2.6.32-24-generic #38-Ubuntu
    Groovy Version: 1.7.3 JVM: 1.6.0_20
  • Number of attachments :
    0

Description

It would appear that properties can't be used in the organisation field (potentially others) of a POM, which is certainly valid for Maven projects. I'm not sure how many other things relating to parent projects (as in my example).

Here's the top lines of the stack trace I get from depending on a project that in turn depends on Guava:
General error during conversion: Error grabbing Grapes – [unresolved dependency: com.google.guava#guava-collections;r03: java.text.ParseException: inconsistent module descriptor file found in 'file:/home/sean/.m2/repository/com/google/guava/guava-collections/r03/guava-collections-r03.pom': bad organisation: expected='com.google.guava' found='$

{parent.groupId}'; ]

java.lang.RuntimeException: Error grabbing Grapes – [unresolved dependency: com.google.guava#guava-collections;r03: java.text.ParseException: inconsistent module descriptor file found in 'file:/home/sean/.m2/repository/com/google/guava/guava-collections/r03/guava-collections-r03.pom': bad organisation: expected='com.google.guava' found='${parent.groupId}

'; ]

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul King added a comment -

I think this is a known problem with Ivy. Can you drop the Ivy jar from here:

http://repo2.maven.org/maven2/org/apache/ivy/ivy/2.2.0-rc1/ivy-2.2.0-rc1.jar

into your Groovy distribution (removing the old one - probably called something like ivy-2.1.0.jar) and see if that helps?

Cheers, Paul.

Show
Paul King added a comment - I think this is a known problem with Ivy. Can you drop the Ivy jar from here: http://repo2.maven.org/maven2/org/apache/ivy/ivy/2.2.0-rc1/ivy-2.2.0-rc1.jar into your Groovy distribution (removing the old one - probably called something like ivy-2.1.0.jar) and see if that helps? Cheers, Paul.
Hide
Permalink
Sean Parsons added a comment -

Ah, that does appear to have fixed the issue, thanks for the prompt response!

Show
Sean Parsons added a comment - Ah, that does appear to have fixed the issue, thanks for the prompt response!
Hide
Permalink
Paul King added a comment -

I upgraded Groovy's version of Ivy, so the next release should also come with the fix.

Show
Paul King added a comment - I upgraded Groovy's version of Ivy, so the next release should also come with the fix.
Hide
Permalink
Stan Devitt added a comment -

There is still a problem. Groovy (or Ivy) seems to be assuming that the packaging = type. This is not a requirement in a maven repository. Example the packaging might be a custom packaging which results in an artifact with a type "jar".

Show
Stan Devitt added a comment - There is still a problem. Groovy (or Ivy) seems to be assuming that the packaging = type. This is not a requirement in a maven repository. Example the packaging might be a custom packaging which results in an artifact with a type "jar".
Hide
Permalink
Paul King added a comment -

Can you give an example, i.e. a @Grab statement that doesn't currently work?

Show
Paul King added a comment - Can you give an example, i.e. a @Grab statement that doesn't currently work?
Hide
Permalink
Stan Devitt added a comment -

Given:

<project>
<modelVersion>4.0.0</modelVersion>
<groupId>company</groupId>
<artifactId>tools</artifactId>
<version>0.0.0.1</version>
<packaging>mypackaging</packaging>

<properties>
<configFile>myjar.conf</configFile>
</properties>

<build>
<plugins>
<plugin>
<groupId>company</groupId>
<artifactId>tools-maven-plugin</artifactId>
<version>1.0.1</version>
<extensions>true</extensions>
</plugin>
</plugins>
</build>
</project>

which deploys an artifact of "type" jar,

@Grab( group="company" , module="tools" , version="0.0.0.1")

complains that it cannot find company#tools;0.0.0.1!mypackaging

It still fails if I clean out my grapes folder and change this to

@Grab( group="company" , module="tools" , ext="jar" , version="0.0.0.1" )

The parser is happy with the "ext=" part (i.e. it complains if I use something else than "ext"), but it still complains about not finding something with an ext = "mypackaging".

The only way I was able to get this to work was to hard code the ivy pattern match to "jar" until the artifact was installed.

Stan

Show
Stan Devitt added a comment - Given: <project> <modelVersion>4.0.0</modelVersion> <groupId>company</groupId> <artifactId>tools</artifactId> <version>0.0.0.1</version> <packaging>mypackaging</packaging> <properties> <configFile>myjar.conf</configFile> </properties> <build> <plugins> <plugin> <groupId>company</groupId> <artifactId>tools-maven-plugin</artifactId> <version>1.0.1</version> <extensions>true</extensions> </plugin> </plugins> </build> </project> which deploys an artifact of "type" jar, @Grab( group="company" , module="tools" , version="0.0.0.1") complains that it cannot find company#tools;0.0.0.1!mypackaging It still fails if I clean out my grapes folder and change this to @Grab( group="company" , module="tools" , ext="jar" , version="0.0.0.1" ) The parser is happy with the "ext=" part (i.e. it complains if I use something else than "ext"), but it still complains about not finding something with an ext = "mypackaging". The only way I was able to get this to work was to hard code the ivy pattern match to "jar" until the artifact was installed. Stan

People

  • Assignee:
    Paul King
    Reporter:
    Sean Parsons
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: