groovy

GroovyScriptEngine doesn't recompile updateted script

Details

  • Number of attachments :
    0

Description

If you run the following java code and alter the executed script while running, it is unpredictable when GroovyScriptEngine recompiles the script. Sometimes it works, sometimes not.

GroovyScriptEngineTest.java
public class GroovyScriptEngineTest {

	public static void main(String[] args) throws Exception {

		GroovyScriptEngine groovyScriptEngine = new GroovyScriptEngine("/home/peddn/groovy");
		
		groovyScriptEngine.getConfig().setMinimumRecompilationInterval(0);
		
		while (true) {

			Class<?> groovyClass = groovyScriptEngine.loadScriptByName("TestPrint.groovy");

			GroovyObject groovyObject = (GroovyObject) groovyClass.newInstance();

			Object[] groovyArgs = {};

			groovyObject.invokeMethod("testPrint", groovyArgs);

                        //check for recompile every half second
			Thread.sleep(500L);

		}

	}

}

class TestPrint {

	public void testPrint() {
		
		System.out.println("hello World");
		
	}
	
}

here some suggestions from a discussion at the mailing list:

I fact I think its kind of bug in GroovyScriptEngine here is code
snippet: 

    protected boolean isSourceNewer(ScriptCacheEntry entry) throws 
ResourceException  { 
        if (entry == null) return true; 
        long time = System.currentTimeMillis(); 

        ScriptCacheEntry newEntry = new 
ScriptCacheEntry(depEntry.scriptClass, time, depEntry.dependencies); 
        scriptCache.put(scriptName, newEntry); 
    }

I think more right solution is using aomthing like this: 

    protected boolean isSourceNewer(ScriptCacheEntry entry) throws 
ResourceException  { 
        if (entry == null) return true; 
        long time = long time = <get entry file lastModified 
timestamp> 

        ScriptCacheEntry newEntry = new 
ScriptCacheEntry(depEntry.scriptClass, time, depEntry.dependencies); 
        scriptCache.put(scriptName, newEntry); 
    }

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guillaume Laforge added a comment -

I'm wondering which version of Groovy's source code you're looking at, as isSourceNewer seems to be pretty different from what you're quoting. And GroovyScriptEngine does some checks like if (entryChangeTime > lastMod) to ensure we're reloading when appropriate.

Show
Guillaume Laforge added a comment - I'm wondering which version of Groovy's source code you're looking at, as isSourceNewer seems to be pretty different from what you're quoting. And GroovyScriptEngine does some checks like if (entryChangeTime > lastMod) to ensure we're reloading when appropriate.
Hide
Permalink
Guillaume Laforge added a comment - - edited

I've reproduced the behaviour with two scripts in the same directory:

With runner.groovy

def gse = new GroovyScriptEngine(".")
gse.config.recompileGroovySource = true
gse.config.minimumRecompilationInterval = 0
		
while (true) {
	def groovyClass = gse.loadScriptByName("script.groovy")
	def groovyObject = groovyClass.newInstance()
	groovyObject.run()
	sleep 500
}

And script.groovy

println "hello Groovy World !"

Changes to the script are sometimes picked up and sometimes not.
I've not really figured out why yet.

Show
Guillaume Laforge added a comment - - edited I've reproduced the behaviour with two scripts in the same directory: With runner.groovy def gse = new GroovyScriptEngine( "." ) gse.config.recompileGroovySource = true gse.config.minimumRecompilationInterval = 0 while ( true ) { def groovyClass = gse.loadScriptByName( "script.groovy" ) def groovyObject = groovyClass.newInstance() groovyObject.run() sleep 500 } And script.groovy println "hello Groovy World !" Changes to the script are sometimes picked up and sometimes not. I've not really figured out why yet.
Hide
Permalink
Guillaume Laforge added a comment -

Using

gse.run("script.groovy", binding)

doesn't change much either, anyway, it's calling the same loadScriptByName() method in the end.

Show
Guillaume Laforge added a comment - Using gse.run( "script.groovy" , binding) doesn't change much either, anyway, it's calling the same loadScriptByName() method in the end.
Hide
Permalink
Guillaume Laforge added a comment -

Should be fixed now.
There was indeed an issue with the reloading and in light of the minimum reloading interval.

Show
Guillaume Laforge added a comment - Should be fixed now. There was indeed an issue with the reloading and in light of the minimum reloading interval.

People

  • Assignee:
    Guillaume Laforge
    Reporter:
    Peter Schmid
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: